Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @latincompass (aka @18438880 , @haierwangwei2005)'s boards to /latincompass #16039

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Jan 25, 2022

Description

At this point in my series of board move PRs, I've started to move boards where I cannot reach the makers beforehand, and have to contact them via the PR itself.

This PR is made without contacting(or failing at contacting) @latincompass ( @18438880 , @haierwangwei2005 ) first, so it would need them to approve it for it to go in.

As there was no prior communication before this PR, I have to ask a few questions:

  • Is the folder name satisfactory?
  • Did I leave anything out?
  • Did I include anything I shouldn't have included?

One of the reasons I'm electing to do this is to get as many PRs in as possible before the breaking change deadline, please stop me in my tracks if this is inappropriate.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 25, 2022
@latincompass
Copy link
Contributor

Thanks a Lot,Sir,I appreciate your work.

@latincompass
Copy link
Contributor

The 18438880 and haierwangwei2005 two Account is also my Account

Copy link
Contributor

@latincompass latincompass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work,Sir

Copy link
Contributor

@haierwangwei2005 haierwangwei2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work,Sir

Copy link

@18438880 18438880 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work,Sir

@latincompass
Copy link
Contributor

latincompass commented Jan 25, 2022 via email

@drashna
Copy link
Member

drashna commented Jan 30, 2022

Merge conflicts

@peepeetee
Copy link
Contributor Author

Merge conflicts

resolved

@drashna drashna merged commit 9e4942b into qmk:develop Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants