Adding Rev41lp keyboard #15895

janlindblom · 2022-01-16T00:22:53Z

Description

Adding support for Rev41lp by @cyril279, cherry-picking original files and adding custom nordic-optimized keymap.

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

left-ctrl < left-shift kc-enter < kc-sftent lower + tab = grave raise + tab = tilde

janlindblom · 2022-01-16T13:07:36Z

I can see now that the commits I cherry-picked from Cyril doesn't fulfill the PR checklist, will go through and fix those, sorry that I didn't notice this before creating the PR.

filterpaper

Suggestions to simplify default keymap.c

keyboards/b_sides/rev41lp/config.h

keyboards/b_sides/rev41lp/keymaps/default/keymap.c

keyboards/b_sides/rev41lp/rules.mk

Co-authored-by: Albert Y <[email protected]>

janlindblom · 2022-01-19T10:34:22Z

Thank you @filterpaper ! I'll check and merge your suggested changes once I'm on my computer again.

Co-authored-by: Albert Y <[email protected]>

keyboards/b_sides/rev41lp/info.json

keyboards/b_sides/rev41lp/keymaps/cyril/config.h

keyboards/b_sides/rev41lp/keymaps/namnlos/config.h

keyboards/b_sides/rev41lp/config.h

keyboards/b_sides/rev41lp/keymaps/cyril/config.h

keyboards/b_sides/rev41lp/keymaps/cyril/keymap.c

keyboards/b_sides/rev41lp/keymaps/namnlos/keymap.c

keyboards/b_sides/rev41lp/keymaps/namnlos/rules.mk

keyboards/b_sides/rev41lp/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

Co-authored-by: Ryan <[email protected]>

keyboards/b_sides/rev41lp/rules.mk

janlindblom · 2022-02-22T14:16:33Z

Thanks @filterpaper , @drashna and @fauxpark for reviewing!

Co-authored-by: Ryan <[email protected]>

janlindblom

Resolved all review comments.

cyril279 · 2022-03-03T14:03:53Z

keyboards/b_sides/rev41lp/readme.md

@@ -0,0 +1,15 @@
+# rev39lp


We mean Rev41lp here, correct?

Oh, yes of course, you’re absolutely right! I’ll fix that when I’ve got access to a computer!

I’ve been meaning to ask you @cyril279 , the keyboard is in the subfolder “keyboards/b_sides” as it is now based on your original qmk fork, should it rather be in a folder named “keyboards/cyril279”? I’ve been planning on getting the rev39lp in the same folder at some point too.

Honestly, I haven't truly settled on a brand for my stuff just yet...
I lean toward 'b_sides' over 'cyril279', but I don't have strong feelings on the matter.

stale · 2022-04-25T05:47:27Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

There was a typo in the title, also changed the description a little.

janlindblom · 2022-05-15T12:31:37Z

This one is going stale, I think everything should be in order by now, the final review changes are resolved and I've built 3 of these now without issue using this code!

keyboards/b_sides/rev41lp/readme.md

keyboards/b_sides/rev41lp/keymaps/namnlos/rules.mk

Co-authored-by: Ryan <[email protected]>

janlindblom · 2022-05-16T06:36:24Z

Thanks @fauxpark, changes implemented!

github-actions · 2022-07-01T02:18:09Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

* [keyboard] Add rev41lp * [keymap] rev41lp: More layer, less clutter * [keymap] rev41lp:whitespace cleanup * [keymap] rev41lp: Remove outer shift & edit homerow timings left-ctrl < left-shift kc-enter < kc-sftent lower + tab = grave raise + tab = tilde * Initial namnlos keymap for rev41lp. * Updated according to PR checklist. * Update keyboards/b_sides/rev41lp/config.h Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/rules.mk Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c Co-authored-by: Albert Y <[email protected]> * Updated to fulfill PR checklist. * Update keyboards/b_sides/rev41lp/info.json Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/config.h Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/cyril/config.h Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/cyril/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/namnlos/keymap.c Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/namnlos/rules.mk Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/rules.mk Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/rules.mk Co-authored-by: Drashna Jaelre <[email protected]> * Update keyboards/b_sides/rev41lp/rules.mk Co-authored-by: Ryan <[email protected]> * Update keyboards/b_sides/rev41lp/readme.md Co-authored-by: Ryan <[email protected]> * Update keyboards/b_sides/rev41lp/readme.md Co-authored-by: Ryan <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/namnlos/keymap.c Co-authored-by: Ryan <[email protected]> * Update keyboards/b_sides/rev41lp/rules.mk Co-authored-by: Ryan <[email protected]> * Adding picture. * Rename README.md to readme.md * Cleaning up in rules.mk. * Moving en- and em-dash from dedicated keys. * Readme fixup. There was a typo in the title, also changed the description a little. * Update keyboards/b_sides/rev41lp/readme.md Co-authored-by: Ryan <[email protected]> * Update keyboards/b_sides/rev41lp/keymaps/namnlos/rules.mk Co-authored-by: Ryan <[email protected]> Co-authored-by: cyril279 <[email protected]> Co-authored-by: Albert Y <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>

cyril279 and others added 5 commits January 15, 2022 21:16

[keyboard] Add rev41lp

66e725d

[keymap] rev41lp: More layer, less clutter

2c98786

[keymap] rev41lp:whitespace cleanup

ef6013f

[keymap] rev41lp: Remove outer shift & edit homerow timings

1fcbe7f

left-ctrl < left-shift kc-enter < kc-sftent lower + tab = grave raise + tab = tilde

Initial namnlos keymap for rev41lp.

4c84956

github-actions bot added keyboard keymap labels Jan 16, 2022

zvecr added the pr_checklist_pending Needs changes as per the PR checklist label Jan 16, 2022

Updated according to PR checklist.

7ed0cf8

filterpaper suggested changes Jan 19, 2022

View reviewed changes

janlindblom and others added 2 commits January 19, 2022 12:32

Update keyboards/b_sides/rev41lp/config.h

743d65a

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/rules.mk

7e504aa

Co-authored-by: Albert Y <[email protected]>

janlindblom and others added 10 commits January 19, 2022 12:00

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

ee07e47

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

4db78b3

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

bafe92f

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

44553b0

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

e9479dd

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

6803ef1

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

6aed2aa

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

1cba7cf

Co-authored-by: Albert Y <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/default/keymap.c

26bce0a

Co-authored-by: Albert Y <[email protected]>

Updated to fulfill PR checklist.

66d1395

drashna requested changes Feb 21, 2022

View reviewed changes

janlindblom and others added 5 commits February 21, 2022 10:55

Update keyboards/b_sides/rev41lp/info.json

d600fcf

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/b_sides/rev41lp/config.h

3f06880

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/cyril/config.h

f84078c

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/cyril/keymap.c

09dfd5d

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/namnlos/keymap.c

bc22ded

Co-authored-by: Drashna Jaelre <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/namnlos/keymap.c

2117c4b

Co-authored-by: Ryan <[email protected]>

fauxpark requested changes Feb 22, 2022

View reviewed changes

keyboards/b_sides/rev41lp/rules.mk Outdated Show resolved Hide resolved

janlindblom and others added 4 commits February 23, 2022 12:43

Update keyboards/b_sides/rev41lp/rules.mk

91f9f77

Co-authored-by: Ryan <[email protected]>

Adding picture.

10cbbe2

Rename README.md to readme.md

818470a

Cleaning up in rules.mk.

57a4b3e

janlindblom commented Mar 3, 2022

View reviewed changes

janlindblom requested a review from fauxpark March 3, 2022 13:59

cyril279 reviewed Mar 3, 2022

View reviewed changes

Moving en- and em-dash from dedicated keys.

e17c8b1

stale bot added the awaiting changes label Apr 25, 2022

Readme fixup.

90b1e7b

There was a typo in the title, also changed the description a little.

stale bot removed the awaiting changes label May 15, 2022

fauxpark requested changes May 15, 2022

View reviewed changes

keyboards/b_sides/rev41lp/readme.md Outdated Show resolved Hide resolved

keyboards/b_sides/rev41lp/keymaps/namnlos/rules.mk Outdated Show resolved Hide resolved

janlindblom and others added 2 commits May 16, 2022 00:39

Update keyboards/b_sides/rev41lp/readme.md

19cd45c

Co-authored-by: Ryan <[email protected]>

Update keyboards/b_sides/rev41lp/keymaps/namnlos/rules.mk

d7cf078

Co-authored-by: Ryan <[email protected]>

janlindblom requested a review from fauxpark May 16, 2022 06:36

janlindblom mentioned this pull request Jun 16, 2022

Sync with QMK: rev41lp keyboard vial-kb/vial-qmk#180

Closed

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 1, 2022

tzarc approved these changes Jul 1, 2022

View reviewed changes

tzarc merged commit 38ca5e9 into qmk:master Jul 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Rev41lp keyboard #15895

Adding Rev41lp keyboard #15895

janlindblom commented Jan 16, 2022

janlindblom commented Jan 16, 2022

filterpaper left a comment

janlindblom commented Jan 19, 2022

janlindblom commented Feb 22, 2022

janlindblom left a comment

cyril279 Mar 3, 2022

janlindblom Mar 3, 2022

janlindblom Mar 3, 2022

cyril279 Mar 3, 2022

stale bot commented Apr 25, 2022

janlindblom commented May 15, 2022

janlindblom commented May 16, 2022

github-actions bot commented Jul 1, 2022

Adding Rev41lp keyboard #15895

Adding Rev41lp keyboard #15895

Conversation

janlindblom commented Jan 16, 2022

Description

Types of Changes

Checklist

janlindblom commented Jan 16, 2022

filterpaper left a comment

Choose a reason for hiding this comment

janlindblom commented Jan 19, 2022

janlindblom commented Feb 22, 2022

janlindblom left a comment

Choose a reason for hiding this comment

cyril279 Mar 3, 2022

Choose a reason for hiding this comment

janlindblom Mar 3, 2022

Choose a reason for hiding this comment

janlindblom Mar 3, 2022

Choose a reason for hiding this comment

cyril279 Mar 3, 2022

Choose a reason for hiding this comment

stale bot commented Apr 25, 2022

janlindblom commented May 15, 2022

janlindblom commented May 16, 2022

github-actions bot commented Jul 1, 2022