Add Winry315 keyboard #15894
Merged
Add Winry315 keyboard #15894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winry315 is a macropad with 3 rotary encoders and 15 (3×5) keys, with optional per-key RGB backlight and underglow.
NO_ACTION_MACRO and NO_ACTION_FUNCTION are no longer needed (the corresponding obsolete features were removed from QMK), and USB_POLLING_INTERVAL_MS now defaults to 1.
Implement via_set_layout_options_kb() instead of using a timer to check for VIA layout option changes.
Apply clang-format with updated configuration; add “clang-format off” comments for parts which become unreadable after clang-format.
Avoid the “winry/winry315: MANUFACTURER in config.h is overwriting manufacturer in info.json” warning by moving the manufacturer name to info.json; move other USB-related data there too. Matrix configuration still left in config.h to keep it together with encoder pins (which are not yet supported in info.json).
fauxpark
approved these changes
Mar 7, 2022
Jrodna
approved these changes
Mar 7, 2022
drashna
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Winry315 is a macropad with 3 rotary encoders and 15 (3×5) keys, with optional per-key RGB backlight and underglow. It is sold on Taobao and AliExpress; unfortunately, the exact “Winry315” name is not mentioned anywhere, and the SpiderIsland shop on AliExpress does not even mention the “Winry” name at all. However, the “Winry315” name was suggested by the actual board vendor/designer (thanks @peepeetee for finding and communicating with them); at least it looks better than the “YD3xn15mx” name that is used by the vendor firmware.
Types of Changes
Checklist