Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Idobao ID87 v2 #15875

Merged
merged 8 commits into from
Mar 8, 2022
Merged

[Keyboard] Idobao ID87 v2 #15875

merged 8 commits into from
Mar 8, 2022

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Jan 14, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 14, 2022
@peepeetee peepeetee marked this pull request as draft January 14, 2022 12:30
drashna
drashna requested changes Jan 30, 2022
View reviewed changes
keyboards/idobao/id87/v2/config.h Outdated Show resolved Hide resolved
@peepeetee peepeetee marked this pull request as ready for review February 6, 2022 06:44
@drashna drashna requested a review from a team February 26, 2022 20:57
@drashna drashna merged commit eb35f58 into qmk:master Mar 8, 2022
@drashna
Copy link
Member

drashna commented Mar 8, 2022

Thanks!

0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@peepeetee @drashna @zykrah
[Keyboard] Idobao ID87 v2 (qmk#15875)
1b92171 
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peepeetee @drashna @fauxpark