Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up NKRO_ENABLE rules #15382

Merged
merged 32 commits into from
Dec 9, 2021
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 2, 2021

Description

Removing outdated, copypasted comments linking to TMK documentation; rules.mk should avoid links that may die in the future (ie. Docsify/Gitbook).

I also considered modifying the comment to mention the NK_TOGG keycode, as enabling the feature does not immediately make QMK send reports over the NKRO interface... however, again, I decided this is really a job for the docs to explain better.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 2, 2021
@fauxpark fauxpark requested a review from a team December 2, 2021 11:39
@fauxpark fauxpark changed the title Nkro rules link remove Tidy up NKRO_ENABLE rules Dec 2, 2021
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this was a fun review.

@fauxpark fauxpark merged commit a8d440e into qmk:master Dec 9, 2021
@fauxpark fauxpark deleted the nkro-rules-link-remove branch December 9, 2021 05:05
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants