[Core] Hotfix for HOLD_ON_OTHER_KEY_PRESS after #11059 #15307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprof
requested changes
Nov 26, 2021
|
Thanks @sigprof I rushed that and I agree that it should be added to the tests. Is this something that you would want to do? |
that broke compilation because of a typo: KEYPRESS should have been KEY_PRESS
KarlK90
force-pushed
the
fix/hold-on-other-key-press
branch
from
b258866
to
17799d9
Compare
drashna
approved these changes
Nov 26, 2021
tzarc
approved these changes
Nov 27, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11059 broke compilation with keyboards that have
HOLD_ON_OTHER_KEY_PRESSbecause of a typo:KEYPRESSshould have beenKEY_PRESS.Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist