Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UART driver API #14839

Merged
merged 7 commits into from
Nov 13, 2021
Merged

Update UART driver API #14839

merged 7 commits into from
Nov 13, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 16, 2021

Description

Renamed uart_putchar() and uart_getchar() to uart_write() and uart_read() respectively. Added uart_transmit() and uart_receive() to match I2C and SPI driver APIs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

docs/uart_driver.md Outdated Show resolved Hide resolved
docs/uart_driver.md Outdated Show resolved Hide resolved
@fauxpark
Copy link
Member Author

I've changed the API to more closely resemble those of the SPI and I2C drivers. Will do some testing later.

@fauxpark fauxpark changed the title Add uart_puts() and uart_gets() Update UART driver API Oct 17, 2021
@fauxpark fauxpark requested review from sigprof, drashna and a team October 17, 2021 12:36
docs/uart_driver.md Outdated Show resolved Hide resolved
keyboards/nullbitsco/common/remote_kb.c Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from sigprof October 17, 2021 22:24
platforms/avr/drivers/uart.c Outdated Show resolved Hide resolved
@zvecr zvecr merged commit 04b51e3 into qmk:develop Nov 13, 2021
@fauxpark fauxpark deleted the uart-string-functions branch November 13, 2021 18:42
@drashna drashna mentioned this pull request Nov 15, 2021
9 tasks
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
* qmk/develop: (32 commits)
  [Keyboard] Add macro3 PCB support (qmk#15131)
  [Keyboard] Add layout options, hotswap version to portal 66 (qmk#14719)
  [Keyboard] Add Bourgeau 75% PCB (qmk#15072)
  [Keyboard] Fix bandominedoni via keymap compilation (qmk#15171)
  Fix additional board sizes for RGB Matrix (qmk#15170)
  kb_elmo/m0116_usb: Fix Configurator Key Sequence (qmk#15147)
  Require explicit enabling of RGB Matrix modes (qmk#15018)
  Reimplements WPM feature to be smaller & precise (qmk#13902)
  Add support for deferred executors. (qmk#14859)
  Add needed include to pointing_device.c (qmk#15167)
  Fix uart function prototypes (qmk#15162)
  Rework and expand Pointing Device support (qmk#14343)
  Partially reinstate CI formatting process (qmk#15155)
  kb_elmo/elmopad: fix macro reference in info.json (qmk#15142)
  kb_elmo/m0110a_usb: Fix Configurator Key Sequence (qmk#15143)
  Update UART driver API (qmk#14839)
  Fix hebrew emoji in langs.md (qmk#15140)
  [Keyboard] Add space between Cradio info.json layout (qmk#15127)
  add wait to unicode for win (qmk#15061)
  [Docs] Correct logic of tap hold statement (qmk#14992)
  ...
lambdalisue added a commit to lambdalisue/qmk_firmware that referenced this pull request May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants