Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tentative Teensy 3.5 support #14420

Merged
merged 5 commits into from
Jul 2, 2022
Merged

Tentative Teensy 3.5 support #14420

merged 5 commits into from
Jul 2, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 13, 2021 •
edited
Loading

Description

Depends on ChibiOS/ChibiOS-Contrib#306

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 13, 2021 09:34
@github-actions github-actions bot added cli qmk cli command python labels Sep 13, 2021
@fauxpark fauxpark marked this pull request as draft September 13, 2021 09:35
@drashna drashna requested a review from a team September 13, 2021 20:15
@fauxpark fauxpark mentioned this pull request Sep 22, 2021
Closed
14 tasks
@fauxpark fauxpark mentioned this pull request Nov 13, 2021
Merged
Erovia
Erovia approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't have the hw to test it.
I recommend a rebase so the new MCU can be added to the MCU2BOOTLOADER list in lib/python/qmk/constants.py.

@Erovia Erovia requested a review from a team March 8, 2022 19:39
@stale
Copy link

stale bot commented Apr 25, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label May 2, 2022
This was referenced May 2, 2022
Closed
Merged
@fauxpark fauxpark marked this pull request as ready for review May 17, 2022 03:11
@drashna
Copy link
Member

drashna commented May 31, 2022

This waiting on anything else?

@fauxpark
Copy link
Member Author

fauxpark commented May 31, 2022 •
edited
Loading

Just contrib submodule update. Still 21.11.x so I don't think there's anything special needs to happen.

@tzarc
Copy link
Member

tzarc commented Jul 2, 2022

Looks like it just needs an update w.r.t. the list of MCUs now that RP2040 is in. Collision on the same line, I'd imagine.

@tzarc tzarc merged commit ac5e6b6 into qmk:develop Jul 2, 2022
@fauxpark fauxpark deleted the teensy_35 branch July 2, 2022 14:27
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@fauxpark @nolanseaton
Tentative Teensy 3.5 support (qmk#14420)
ad9756b 
* Tentative Teensy 3.5 support

* Set firmware format to .hex for ARM Teensys

* Got to "device descriptor failed" by comparing with Teensy 3.6 code

* Drop down to 96MHz...

* Bump back up to 120MHz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core documentation enhancement keyboard python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @drashna @tzarc @Erovia