Add elephant42 keyboard #14336

diastremskii · 2021-09-06T20:33:55Z

This PR adds the elephant42 keyboard

Description

This is a split keyboard with 3x5+2 vertically staggered keys and 4 thumb keys.

/cc @illness072. Btw would be great if you could check the keymap please, I took it from the fork, but perhaps something needs to be changed.

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/elephant42/config.h

keyboards/elephant42/keymaps/default/keymap.c

keyboards/elephant42/lib/glcdfont.c

keyboards/elephant42/rules.mk

diastremskii · 2021-09-10T14:10:24Z

Thank you for a review! Addressed the comments

diastremskii · 2021-10-17T09:22:10Z

Ping? 🥺👉 👈

drashna · 2021-10-18T04:25:48Z

Ping? 🥺👉 👈

No worries about the ping, it's been a ... .while, so it's absolutely understandable. However ...

keyboards/elephant42/info.json

keyboards/elephant42/keymaps/default/config.h

keyboards/elephant42/config.h

keyboards/elephant42/keymaps/via/config.h

keyboards/elephant42/rules.mk

drashna · 2021-10-18T04:31:57Z

keyboards/elephant42/keymaps/default/keymap.c

+ return true;
+}
+
+void oled_task_user(void) {


Ideally, I'd like this in the keyboard's c file, that way there is an actual default, and if users don't specify one, it will still work just fine. This is especially useful for the QMK Configurator.

Hmm, but there is a different number of layers in default and VIA keymaps 🤔
I guess I can add an "empty" layer to default keymap, or would it be all right to leave as it is now?

noroadsleft

Additionally, any oled_task_user() functions need to be bool signature (bool oled_task_user(void)) and return false; before existing.

keyboards/elephant42/rules.mk

stale · 2022-04-16T09:33:35Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

diastremskii · 2022-04-20T19:08:17Z

@drashna @noroadsleft Thank you for reviews! Addressed the comments

keyboards/elephant42/config.h

drashna · 2022-04-23T21:15:28Z

keyboards/elephant42/elephant42.c

+ LED_FLAG_UNDERGLOW, LED_FLAG_UNDERGLOW, LED_FLAG_UNDERGLOW, LED_FLAG_UNDERGLOW, LED_FLAG_UNDERGLOW, LED_FLAG_UNDERGLOW
+ }
+};
+#endif


Suggested change

#endif

#endif

#ifdef OLED_ENABLE

# define STEPS 32

uint8_t keypresses = 0;

bool process_record_kb(uint16_t keycode, keyrecord_t *record) {

if (record->event.pressed) {

keypresses = (keypresses + 1) % STEPS;

}

return process_record_user(keycode, record);

}

bool oled_task_kb(void) {

if (!oled_task_user()) {

return false;

}

if (is_keyboard_master()) {

static char layer_names[NUMBER_OF_LAYERS][10] = {"Default", "Lower", "Raise", "Adjust"};

static char l1[] = " \x94\x95\x96\x97";

static char l2[] = " \xB4\xB5\xB6\xB7";

static char r1[] = " \x98\x99\x9A\x9B";

static char r2[] = " \xB8\xB9\xBA\xBB";

int iconShift = keypresses % STEPS;

if (iconShift > STEPS / 2) {

iconShift = STEPS - iconShift;

}

bool goingLeft = keypresses < STEPS / 2;

oled_write_P(PSTR("Layer: "), false);

oled_write_ln(layer_names[get_highest_layer(layer_state)], false);

oled_advance_page(true);

oled_write_ln((goingLeft ? l1 : r1) + iconShift, false);

oled_write_ln((goingLeft ? l2 : r2) + iconShift, false);

} else {

oled_advance_page(true);

static const char PROGMEM logo[] = {

0x8f,0x90,0x91,0x92,0x93,0x80,0x81,0x82,0x83,0x84,0x85,0x86,0x87,0x88,0x89,0x8a,0x8b,0x8c,0x8d,0x8e,0x0a,

0xaf,0xb0,0xb1,0xb2,0xb3,0xa0,0xa1,0xa2,0xa3,0xa4,0xa5,0xa6,0xa7,0xa8,0xa9,0xaa,0xab,0xac,0xad,0xae,0x0a,

0xcf,0xd0,0xd1,0xd2,0xd3,0xc0,0xc1,0xc2,0xc3,0xc4,0xc5,0xc6,0xc7,0xc8,0xc9,0xca,0xcb,0xcc,0xcd,0xce,0

};

oled_write_ln_P(logo, false);

}

return true;

}

#endif

Hmmmm, sorry, not sure what would a proper way to define it :(
I mean there is a reference to NUMBER_OF_LAYERS (oled_task_kb depends on the number of layers) and different keymaps can have different number of layers 🤔

well, might be worth just using 4 for that. the default keymap uses 3, and the via keymap uses 4. So just setting them may be fine. And if a user needs to change them, it can be done simply enough.

noroadsleft

Looks good to me.

github-actions · 2022-06-26T02:17:21Z

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 6, 2021

diastremskii force-pushed the feat/elephant42-keyboard branch from 2a4b389 to 6a053b7 Compare September 6, 2021 20:34

drashna requested changes Sep 8, 2021

View reviewed changes

diastremskii force-pushed the feat/elephant42-keyboard branch from f8ef464 to 6a053b7 Compare September 9, 2021 20:25

drashna requested changes Oct 18, 2021

View reviewed changes

noroadsleft requested changes Jan 7, 2022

View reviewed changes

keyboards/elephant42/rules.mk Outdated Show resolved Hide resolved

stale bot added the awaiting changes label Apr 16, 2022

diastremskii added 2 commits April 20, 2022 18:26

Add elephant42 keyboard

99cf576

Address review comments

1dccb41

diastremskii force-pushed the feat/elephant42-keyboard branch from a42dbf9 to 1dccb41 Compare April 20, 2022 15:27

stale bot removed the awaiting changes label Apr 20, 2022

Address review comments

aa7bc17

drashna requested changes Apr 23, 2022

View reviewed changes

noroadsleft approved these changes May 2, 2022

View reviewed changes

Remove deprecated definitions

4058f9c

github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 26, 2022

tzarc approved these changes Jul 2, 2022

View reviewed changes

tzarc merged commit f2f88bc into qmk:master Jul 2, 2022

casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022

Add elephant42 keyboard (qmk#14336)

040ca23

schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022

Add elephant42 keyboard (qmk#14336)

7c147f3

nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023

Add elephant42 keyboard (qmk#14336)

5738afb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add elephant42 keyboard #14336

Add elephant42 keyboard #14336

diastremskii commented Sep 6, 2021 •

edited

Loading

diastremskii commented Sep 10, 2021

diastremskii commented Oct 17, 2021 •

edited

Loading

drashna commented Oct 18, 2021

drashna Oct 18, 2021

diastremskii Apr 20, 2022 •

edited

Loading

noroadsleft left a comment

stale bot commented Apr 16, 2022

diastremskii commented Apr 20, 2022

drashna Apr 23, 2022

diastremskii May 9, 2022

drashna May 11, 2022

noroadsleft left a comment

github-actions bot commented Jun 26, 2022

-#endif
+#endif
+#ifdef OLED_ENABLE
+# define STEPS 32
+uint8_t keypresses = 0;
+bool process_record_kb(uint16_t keycode, keyrecord_t *record) {
+ if (record->event.pressed) {
+ keypresses = (keypresses + 1) % STEPS;
+ }
+ return process_record_user(keycode, record);
+}
+bool oled_task_kb(void) {
+ if (!oled_task_user()) {
+ return false;
+ }
+ if (is_keyboard_master()) {
+ static char layer_names[NUMBER_OF_LAYERS][10] = {"Default", "Lower", "Raise", "Adjust"};
+ static char l1[] = " \x94\x95\x96\x97";
+ static char l2[] = " \xB4\xB5\xB6\xB7";
+ static char r1[] = " \x98\x99\x9A\x9B";
+ static char r2[] = " \xB8\xB9\xBA\xBB";
+ int iconShift = keypresses % STEPS;
+ if (iconShift > STEPS / 2) {
+ iconShift = STEPS - iconShift;
+ }
+ bool goingLeft = keypresses < STEPS / 2;
+ oled_write_P(PSTR("Layer: "), false);
+ oled_write_ln(layer_names[get_highest_layer(layer_state)], false);
+ oled_advance_page(true);
+ oled_write_ln((goingLeft ? l1 : r1) + iconShift, false);
+ oled_write_ln((goingLeft ? l2 : r2) + iconShift, false);
+ } else {
+ oled_advance_page(true);
+ static const char PROGMEM logo[] = {
+x8f,0x90,0x91,0x92,0x93,0x80,0x81,0x82,0x83,0x84,0x85,0x86,0x87,0x88,0x89,0x8a,0x8b,0x8c,0x8d,0x8e,0x0a,
+xaf,0xb0,0xb1,0xb2,0xb3,0xa0,0xa1,0xa2,0xa3,0xa4,0xa5,0xa6,0xa7,0xa8,0xa9,0xaa,0xab,0xac,0xad,0xae,0x0a,
+xcf,0xd0,0xd1,0xd2,0xd3,0xc0,0xc1,0xc2,0xc3,0xc4,0xc5,0xc6,0xc7,0xc8,0xc9,0xca,0xcb,0xcc,0xcd,0xce,0
+ };
+ oled_write_ln_P(logo, false);
+ }
+ return true;
+}
+#endif

Add elephant42 keyboard #14336

Add elephant42 keyboard #14336

Conversation

diastremskii commented Sep 6, 2021 • edited Loading

Description

Types of Changes

Checklist

diastremskii commented Sep 10, 2021

diastremskii commented Oct 17, 2021 • edited Loading

drashna commented Oct 18, 2021

drashna Oct 18, 2021

Choose a reason for hiding this comment

diastremskii Apr 20, 2022 • edited Loading

Choose a reason for hiding this comment

noroadsleft left a comment

Choose a reason for hiding this comment

stale bot commented Apr 16, 2022

diastremskii commented Apr 20, 2022

drashna Apr 23, 2022

Choose a reason for hiding this comment

diastremskii May 9, 2022

Choose a reason for hiding this comment

drashna May 11, 2022

Choose a reason for hiding this comment

noroadsleft left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 26, 2022

diastremskii commented Sep 6, 2021 •

edited

Loading

diastremskii commented Oct 17, 2021 •

edited

Loading

diastremskii Apr 20, 2022 •

edited

Loading