Add macOS-friendly keymap for GMMK Pro (ANSI) #14333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvuc
changed the title
zvuc
force-pushed
the
gmmk-pro-ansi-zvuc
branch
2 times, most recently
from
753379c
to
e9a8321
Compare
zvecr
requested changes
Sep 6, 2021
|
I found a few places I want to change / improve so I'll request a review again after adding a few more commits. Sorry for the confusion! |
zvuc
force-pushed
the
gmmk-pro-ansi-zvuc
branch
from
2d5a986
to
62b9958
Compare
zvuc
force-pushed
the
gmmk-pro-ansi-zvuc
branch
from
3b26963
to
c8ba376
Compare
drashna
approved these changes
Sep 15, 2021
|
Hi, just checking in here again after a while. Is there anything else I need to do regarding this PR to get this merged to master? 😄 @zvecr |
|
Thank you for your contribution! |
|
Thanks! |
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
* Add macOS keymap for GMMK Pro (ANSI) * Change macOS keymap directory name to lowercase * Add toggleable layer with alternative keymap for function row * Update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GMMK Pro is a great entry keyboard for many people getting into the hobby (including me), and I'm pretty sure there are many macOS users out there although we're a minority in the Custom Mech Keys world. While the keyboard is usable in macOS out-of-the-box, Glorious does not (yet) provide their Glorious Core software for macOS; so with stock firmware, there aren't any ways to customize layouts on the hardware level unless you turn to software-based override solutions such as Karabiner Elements. This is my attempt to try to create the most macOS-like experience on the GMMK Pro, taking close notes from Apple's Magic Keyboard, also referencing code from other community members.
Types of Changes
Checklist