Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Absolute Designs AD65 Keyboard #14279

Closed
wants to merge 3 commits into from
Closed

Added Absolute Designs AD65 Keyboard #14279

wants to merge 3 commits into from

Conversation

mrnoisytiger
Copy link
Contributor

Description

Added Absolute Designs AD65 Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 2, 2021
@mrnoisytiger mrnoisytiger mentioned this pull request Sep 2, 2021
Merged
6 tasks
@mrnoisytiger
Copy link
Contributor Author

Bump for review @drashna

drashna
drashna requested changes Sep 8, 2021
View reviewed changes
keyboards/fjlabs/ad65/rules.mk
# Build Options
# change yes to no to disable
#
BOOTMAGIC_ENABLE = lite # Virtual DIP switch configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BOOTMAGIC_ENABLE = lite # Virtual DIP switch configuration
BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite

Copy link
Contributor Author

@mrnoisytiger mrnoisytiger Sep 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drashna Can you make this something I can click to accept the suggestion? I had to destroy this fork due to problems with the submodules.

Alternatively, I can open a second pull request to fix this once this PR is merged. Please advise.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I can't. Sorry.

@mrnoisytiger
Copy link
Contributor Author

Closing to open new pull request with updated fork.

@mrnoisytiger mrnoisytiger mentioned this pull request Sep 11, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrnoisytiger @drashna