Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qwiic drivers #14174

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Remove qwiic drivers #14174

merged 1 commit into from
Oct 9, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 26, 2021

Description

Doesnt make sense to have 3 different implementations of oled drivers. We have been requiring PRs to not target the QWIIC version for a little while so its finally time for it to go.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the feature/remove_qwiic branch 2 times, most recently from 560fd40 to 58d07b3 Compare August 26, 2021 16:48
@zvecr zvecr mentioned this pull request Sep 12, 2021
14 tasks
@zvecr
Copy link
Member Author

zvecr commented Sep 12, 2021

@awkannan did you want to perform the migration of the satisfaction75, or are you happy for me to do so?

https://github.com/zvecr/qmk_firmware/tree/feature/sat75_oled contains some initial stubs but a lot of the render needs re-implementing.

Edit: going to push forward and implement... something

@zvecr zvecr marked this pull request as ready for review October 9, 2021 13:47
@zvecr zvecr merged commit dace4d5 into qmk:develop Oct 9, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants