Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for M65S #14027

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Add initial support for M65S #14027

merged 3 commits into from
Sep 13, 2021

Conversation

Gondolindrim
Copy link
Contributor

@Gondolindrim Gondolindrim commented Aug 16, 2021

Description

Adds support for Mode's SixtyFive M65S PCB. This is the solderable version; two more hotswap versions M65HA and M65HI will be PR'd once final prototypes are manufactured.

The keyboard.c features an I2C-EEPROM code for VIA compatibility (developed with @tzarc ) with adjacent debugging messages; for the scaled-release, debugging is turned off, hence its commenting in board_init().

Both VIA and non-VIA firmwares were thoroughly prototyped.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 16, 2021
keyboards/mode/m65s/rules.mk Outdated Show resolved Hide resolved
Co-authored-by: Drashna Jaelre <[email protected]>
keyboards/mode/m65s/m65s.c Outdated Show resolved Hide resolved
keyboards/mode/m65s/rules.mk Outdated Show resolved Hide resolved
@Jaicob
Copy link

Jaicob commented Sep 13, 2021

@zvecr can you please give this another look, or assign a different review who is available to?

@tzarc tzarc merged commit eee5533 into qmk:master Sep 13, 2021
cori pushed a commit to cori/qmk_firmware that referenced this pull request Sep 19, 2021
* Add initial support for M65S

* Remove LTO_ENABLE from rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Removed defs in rules.mk, remove EEPROM debug code in m65s.c

Co-authored-by: Drashna Jaelre <[email protected]>
sar23b pushed a commit to sar23b/qmk_firmware that referenced this pull request Sep 19, 2021
* Add initial support for M65S

* Remove LTO_ENABLE from rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Removed defs in rules.mk, remove EEPROM debug code in m65s.c

Co-authored-by: Drashna Jaelre <[email protected]>
billyjbryant pushed a commit to MetalBoards/qmk_firmware that referenced this pull request Sep 29, 2021
* Add initial support for M65S

* Remove LTO_ENABLE from rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Removed defs in rules.mk, remove EEPROM debug code in m65s.c

Co-authored-by: Drashna Jaelre <[email protected]>
0xcharly pushed a commit to 0xcharly/qmk_firmware that referenced this pull request Oct 25, 2021
* Add initial support for M65S

* Remove LTO_ENABLE from rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Removed defs in rules.mk, remove EEPROM debug code in m65s.c

Co-authored-by: Drashna Jaelre <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Add initial support for M65S

* Remove LTO_ENABLE from rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Removed defs in rules.mk, remove EEPROM debug code in m65s.c

Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants