Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly state that VIA should not be enabled in the default keymap. #13803

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Explicitly state that VIA should not be enabled in the default keymap. #13803

merged 1 commit into from
Jul 30, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jul 30, 2021

Description

As per the title. Clarification.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 30, 2021 23:19
@tzarc tzarc merged commit b459f31 into qmk:master Jul 30, 2021
@tzarc tzarc deleted the pr_checklist_via branch August 4, 2021 02:34
CharlesSchimmel pushed a commit to CharlesSchimmel/qmk_firmware that referenced this pull request Aug 8, 2021
@tzarc
Explicitly state that VIA should not be enabled in the default keymap. (
9dc1594 
qmk#13803)
@shelaf shelaf mentioned this pull request Aug 15, 2021
Merged
14 tasks
VictorIsaacChavezEscamilla pushed a commit to VictorIsaacChavezEscamilla/qmk_firmware that referenced this pull request Aug 28, 2021
@tzarc
Explicitly state that VIA should not be enabled in the default keymap. (
93fc22f 
qmk#13803)
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@tzarc @nhongooi
Explicitly state that VIA should not be enabled in the default keymap. (
25e464d 
qmk#13803)
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@tzarc
Explicitly state that VIA should not be enabled in the default keymap. (
fcc1336 
qmk#13803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @ridingqwerty @zvecr