Migrate platform independent code from tmk_core -> quantum

[zvecr]

Description

Trying to catch the end of the develop cycle to minimise merge issues

git mv tmk_core/common/*action* quantum/
git mv tmk_core/common/key* quantum/
git mv tmk_core/common/eeconfig.* quantum/

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[tzarc]

Need to retarget develop.

[zvecr]

Will rebase closer to develop closing, to minimise any potential issues with other user PRs.

[drashna]

I'm not sure why, but this break split side detection. EE Hands, master left/right doesn't matter, the USB side registers as left. Period. Confirmed on 3 different boards. And both with merging into a branch and checkout out this PR directly.

[sigprof]

I'm not sure why, but this break split side detection.

Probably because these files get linked in a different order after applying the PR:

quantum/split_common/split_util.c:__attribute__((weak)) bool is_keyboard_left(void) {
tmk_core/common/keyboard.c:__attribute__((weak)) bool is_keyboard_left(void) { return true; }

build_keyboard.mk contains:

SRC += $(KEYBOARD_SRC) \
    $(KEYMAP_C) \
    $(QUANTUM_SRC)
...
# this appends $(QUANTUM_DIR)/split_common/split_util.c to $(QUANTUM_SRC) if requested
include common_features.mk
...
SRC += $(TMK_COMMON_SRC)

So before the PR quantum/split_common/split_util.c was listed in $(SRC) before tmk_core/common/keyboard.c, but after the PR the order of those files is reversed — and this apparently affects the choice between multiple weak definitions of the is_keyboard_left symbol.

Note that the behavior of ld in the presence of multiple weak definitions of a symbol does not seem to be documented anywhere, therefore relying on the first weak definition overriding subsequent weak definitions might actually be unsafe. However, this might not be the only place in QMK where multiple different weak definitions of the same symbol are used.

[zvecr]

Kinda meh, but the latest commit should resolve the split issues. Given the other SPLIT_KEYBOARD guards in quantum, its no worse, but overall it would be better to introduce nicer longer term abstractions for some of this stuff.

[drashna]

Can confirm it works

[drashna]

Found an issue.

quantum/via.h:19:10: fatal error: tmk_core/common/eeconfig.h: No such file or directory
 #include "tmk_core/common/eeconfig.h"  // for EECONFIG_SIZE