Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dc01/left so that it doesn't throw a warning #13653

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix dc01/left so that it doesn't throw a warning #13653

merged 2 commits into from
Jul 23, 2021

Conversation

skullydazed
Copy link
Member

Description

Fixes this error:

☒ dc01/left: MATRIX_COLS is inconsistent with the size of MATRIX_COL_PINS: 6 != 21

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed
Copy link
Member Author

@yiancar are you ok with this approach?

@yiancar
Copy link
Contributor

yiancar commented Jul 23, 2021

looks ok to me. @keyboard-magpie Could you please test this change in your prototype before we give the goahead?

@drashna drashna merged commit fa32c66 into develop Jul 23, 2021
@drashna drashna deleted the dc01/left_fix branch July 23, 2021 15:06
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@skullydazed @nhongooi
[Keyboard] Fix dc01/left so that it doesn't throw a warning (qmk#13653)
20f5c58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skullydazed @yiancar @drashna @fauxpark