Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboards/sol rev2 fix #13533

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Keyboards/sol rev2 fix #13533

merged 2 commits into from
Jul 13, 2021

Conversation

XScorpion2
Copy link
Contributor

Description

Fixed rgbkb/sol/rev2/config.h config.h. It was not building after changes from #13349 due to missing default led counts. Reordered the defines and added additional comments for readability.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core dependencies documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels Jul 13, 2021
@XScorpion2 XScorpion2 changed the base branch from master to develop July 13, 2021 02:33
@github-actions github-actions bot removed via Adds via keymap and/or updates keyboard for via support documentation core cli qmk cli command python keymap dependencies translation labels Jul 13, 2021
@drashna
Copy link
Member

drashna commented Jul 13, 2021

Still errors out:

Compiling: keyboards/rgbkb/sol/rev2/rev2.c                                                         keyboards/rgbkb/sol/rev2/rev2.c:12:13: error: 'FULLHAND_LEDS' undeclared here (not in a function)
 #define LO (FULLHAND_LEDS / 2)
             ^~~~~~~~~~~~~
keyboards/rgbkb/sol/rev2/rev2.c:13:8: note: in expansion of macro 'LO'
     {  LO+62,  LO+63,  LO+64,  LO+65,  LO+66,  LO+67,  LO+68 },
        ^~

@drashna drashna requested a review from a team July 13, 2021 02:52
@drashna drashna added the bug label Jul 13, 2021
@tzarc tzarc merged commit 1ae4d52 into qmk:develop Jul 13, 2021
@XScorpion2 XScorpion2 deleted the keyboards/sol_rev2_fix branch September 22, 2021 02:27
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Fixed a recent develop error

* minor fix cause I am tired
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants