Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 'show_build_options' target #13425

Merged
merged 2 commits into from
Jul 3, 2021
Merged

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 3, 2021

  • Align the output to maximize readibility
  • Add Bootloader to listed output

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

* Align the output to maximize readibility
* Add Bootloader to listed output
@drashna drashna requested a review from a team July 3, 2021 05:05
@github-actions github-actions bot added the core label Jul 3, 2021
@drashna
Copy link
Member Author

drashna commented Jul 3, 2021

I'd like to get the rest formatted too, but that's ... make, and I'm not up for that, right now.

@mtei
Copy link
Contributor

mtei commented Jul 3, 2021

for example:

diff --git a/show_options.mk b/show_options.mk
index cd04f6a0d..1520ac15c 100644
--- a/show_options.mk
+++ b/show_options.mk
@@ -86,7 +86,7 @@ OTHER_OPTION_NAMES = \
   LTO_ENABLE
 
 define NAME_ECHO
-       @echo "  $1 = $($1)             # $(origin $1)"
+       @printf "  %-30s = %-16s # %s\\n" "$1" "$($1)" "$(origin $1)"
 
 endef

@drashna drashna merged commit 0b22783 into qmk:develop Jul 3, 2021
@drashna drashna deleted the build/show_options branch July 3, 2021 14:43
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 4, 2021
…velop

* 'develop' of https://github.com/qmk/qmk_firmware: (37 commits)
  [Keyboard] Add CX60 (qmk#13402)
  Specskeys Configurator Bugfix and Refactor (qmk#13439)
  [Keyboard] IDOBAO ID67 (qmk#13378)
  [Keyboard] ortho boards from the technik gb (qmk#13382)
  [Keyboard] Add soldered variant of Titan 65 keyboard.  (qmk#13270)
  Pisces: correct layout macro reference in info.json (qmk#13410)
  [Keymap] Update Miryoku (qmk#13307)
  [Keyboard] Add wings42 keyboard (qmk#12734)
  [Keyboard] Added LAYOUT_60_iso_split_rshift to ok60 (qmk#12902)
  [Keymap] Jonavin merc additional encoder functionality (qmk#13039)
  [Bug] Pachi RGB - fix rgb placement (qmk#13428)
  AW20216 use register increment for framebuffer flushes (qmk#13430)
  Improve 'show_build_options' target (qmk#13425)
  [Keymap] gmmk pro keymap with numpad, enhanced encoder functionality and Win key lock (qmk#13406)
  [Keymap] Jonavin quefrency keymap add encoder functionality + 2tap Shift CAPSLOCK (qmk#13376)
  [Docs] RGB Matrix Caps Lock and Layer indicator example (qmk#13367)
  [Keymap] Add stanrc85 community layout (qmk#13338)
  [Keymap] 2Moons-JP Keymap Update (qmk#13279)
  [Keyboard] Added pistachio rev2 (qmk#13248)
  [Keymap] niclake - Keymap updates - Boardwalk updates & DZ60 create (qmk#13245)
  ...
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* Improve 'show_build_options' target

* Align the output to maximize readibility
* Add Bootloader to listed output

* Also alighn build options

Thanks mtei!
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* Improve 'show_build_options' target

* Align the output to maximize readibility
* Add Bootloader to listed output

* Also alighn build options

Thanks mtei!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants