Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the size of the textpad to allow for 33 row keyboards #13319

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Expand the size of the textpad to allow for 33 row keyboards #13319

merged 1 commit into from
Jun 24, 2021

Conversation

skullydazed
Copy link
Member

Description

If a keyboard is taller than 16 rows qmk info -m blows up. This expands that to allow up to 33 rows.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team June 24, 2021 02:01
@github-actions github-actions bot added cli qmk cli command python labels Jun 24, 2021
@skullydazed skullydazed mentioned this pull request Jun 24, 2021
Merged
6 tasks
@skullydazed skullydazed merged commit 42f4528 into master Jun 24, 2021
skullydazed added a commit that referenced this pull request Jun 24, 2021
@skullydazed
expand the size of the textpad to allow for taller keyboards (#13319)
02c92b8
sperly pushed a commit to sperly/qmk_firmware that referenced this pull request Jul 2, 2021
@skullydazed @sperly
expand the size of the textpad to allow for taller keyboards (qmk#13319)
5cccf3e
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
@skullydazed @jakeprime
expand the size of the textpad to allow for taller keyboards (qmk#13319)
6dbfc6f
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@skullydazed @HokieGeek
expand the size of the textpad to allow for taller keyboards (qmk#13319)
046cd3e
@fauxpark fauxpark deleted the extend_info_size branch August 3, 2021 10:17
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@skullydazed @wox
expand the size of the textpad to allow for taller keyboards (qmk#13319)
6381084
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@skullydazed @nhongooi
expand the size of the textpad to allow for taller keyboards (qmk#13319)
8b00437
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
expand the size of the textpad to allow for taller keyboards (qmk#13319)
4977931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skullydazed @drashna @tzarc @fauxpark