Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flygone60 rev3 #13280

Merged
merged 7 commits into from
Jul 1, 2021
Merged

Added flygone60 rev3 #13280

merged 7 commits into from
Jul 1, 2021

Conversation

CheeseL0ver
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 21, 2021
@drashna drashna requested a review from a team June 26, 2021 05:57
fauxpark
fauxpark requested changes Jun 26, 2021
View reviewed changes
keyboards/flygone60/rev3/readme.md Outdated Show resolved Hide resolved
keyboards/flygone60/rev3/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/flygone60/rev3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@CheeseL0ver
Copy link
Contributor Author

I added the requested changes. @fauxpark

sigprof
sigprof requested changes Jun 26, 2021
View reviewed changes
keyboards/flygone60/rev3/config.h Outdated Show resolved Hide resolved
keyboards/flygone60/rev3/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/flygone60/rev3/keymaps/via/keymap.c Show resolved Hide resolved
@CheeseL0ver
Copy link
Contributor Author

I have removed the left over defines for the spit keyboard @sigprof

@CheeseL0ver CheeseL0ver requested a review from sigprof June 26, 2021 17:34
sigprof
sigprof requested changes Jun 26, 2021
View reviewed changes
keyboards/flygone60/rev3/readme.md Outdated Show resolved Hide resolved
@CheeseL0ver
Copy link
Contributor Author

Fixed kit link as pointed out by @sigprof

@CheeseL0ver CheeseL0ver requested a review from sigprof June 26, 2021 20:59
@drashna drashna merged commit d8c4919 into qmk:master Jul 1, 2021
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
@CheeseL0ver @fauxpark
@sigprof @jakeprime
[Keyboard] Added flygone60 rev3 (qmk#13280)
ddd4119 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Sergey Vlasov <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@CheeseL0ver @fauxpark
@sigprof @HokieGeek
[Keyboard] Added flygone60 rev3 (qmk#13280)
29a9b35 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Sergey Vlasov <[email protected]>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
@CheeseL0ver @fauxpark
@sigprof @wox
[Keyboard] Added flygone60 rev3 (qmk#13280)
95d4d13 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Sergey Vlasov <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@CheeseL0ver @fauxpark
@sigprof @nhongooi
[Keyboard] Added flygone60 rev3 (qmk#13280)
51e769c 
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Sergey Vlasov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigprof sigprof sigprof approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CheeseL0ver @sigprof @drashna @fauxpark