Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboards/RGBKB/Mün #13239

Merged
merged 6 commits into from
Jun 26, 2021
Merged

Keyboards/RGBKB/Mün #13239

merged 6 commits into from
Jun 26, 2021

Conversation

XScorpion2
Copy link
Contributor

Description

RGBKB's Mun keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot removed the core label Jun 18, 2021
@XScorpion2 XScorpion2 changed the title Keyboards/mun Keyboards/RGBKB/Mün Jun 18, 2021
drashna
drashna requested changes Jun 19, 2021
View reviewed changes
keyboards/rgbkb/common/common_oled.c Show resolved Hide resolved
keyboards/rgbkb/common/common_oled.h Show resolved Hide resolved
keyboards/rgbkb/common/glcdfont.c Show resolved Hide resolved
keyboards/rgbkb/common/touch_encoder.c Show resolved Hide resolved
keyboards/rgbkb/mun/halconf.h Show resolved Hide resolved
keyboards/rgbkb/mun/rev1/config.h Show resolved Hide resolved
keyboards/rgbkb/mun/mun.h Outdated Show resolved Hide resolved
keyboards/rgbkb/mun/rev1/rev1.c Show resolved Hide resolved
keyboards/rgbkb/mun/rev1/rev1.h Show resolved Hide resolved
keyboards/rgbkb/mun/rev1/rgbkb_mun.json Outdated Show resolved Hide resolved
@Legonut
Copy link
Contributor

Legonut commented Jun 22, 2021

Approved by RGBKB

@drashna
Copy link
Member

drashna commented Jun 26, 2021

Thanks!

@drashna drashna merged commit 8b05908 into qmk:develop Jun 26, 2021
fauxpark
fauxpark reviewed Jun 26, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a few checklist problems and should not have been merged in its current state.

@XScorpion2
Copy link
Contributor Author

This PR has a few checklist problems and should not have been merged in its current state.

I'll reread the checklist and go fix them...been a while since I read that and it's probably changed.

@XScorpion2 XScorpion2 deleted the keyboards/mun branch September 19, 2021 19:36
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@XScorpion2 @nhongooi
Keyboards/RGBKB/Mün (qmk#13239)
0e7a392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@kageurufu kageurufu kageurufu approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@XScorpion2 @Legonut @drashna @kageurufu @fauxpark