Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of bcat keymaps and userspace #13224

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Minor cleanup of bcat keymaps and userspace #13224

merged 4 commits into from
Aug 3, 2021

Conversation

bcat
Copy link
Contributor

@bcat bcat commented Jun 17, 2021

Description

Added license headers to all my keymap/userspace sources still missing them, clang-formatted my source files, tweaked keymap code in insubstantial ways, and updates some of my keymap readme files. There shouldn't be any functional changes in this PR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@stale
Copy link

stale bot commented Aug 3, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@bcat
Copy link
Contributor Author

bcat commented Aug 3, 2021

@drashna, looks like this got lost in the shuffle. I'm not in a rush, but the stalebot is getting impatient so I figured I'd ask:

  1. Do I need to do anything special to get this in the queue for other reviewers? Or is there just a big backlog of PRs? (Totally understandable if so.)
  2. I've got some additional keymap/userspace changes ready to go. I'd been waiting to send a PR for them until after this PR was merged, since this one is just a cleanup. But would it be easier to review if I dropped this PR and sent a new one with the subsequent changes integrated as well?

Thanks!

@drashna drashna requested a review from a team August 3, 2021 02:12
@stale stale bot removed the awaiting changes label Aug 3, 2021
@drashna
Copy link
Member

drashna commented Aug 3, 2021

Might as well add it to this, yeah.

@drashna drashna merged commit 8533442 into qmk:master Aug 3, 2021
@bcat
Copy link
Contributor Author

bcat commented Aug 3, 2021

Might as well add it to this, yeah.

Sorry, I didn't catch this in time before it was merged. No big deal, I can send a follow-up PR. I totally get there's a massive amount of incoming PRs and I'm not in any rush on this stuff. :)

Thanks all for the reviews BTW!

@bcat bcat deleted the bcat_cleanup branch August 4, 2021 01:27
CharlesSchimmel pushed a commit to CharlesSchimmel/qmk_firmware that referenced this pull request Aug 8, 2021
VictorIsaacChavezEscamilla pushed a commit to VictorIsaacChavezEscamilla/qmk_firmware that referenced this pull request Aug 28, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants