[Keyboard] Fix revision issues with Kyria #13208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duckle29
approved these changes
Jun 14, 2021
fauxpark
requested changes
Jun 17, 2021
Co-authored-by: Ryan <[email protected]>
fauxpark
approved these changes
Jun 18, 2021
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
Co-authored-by: Ryan <[email protected]>
wox
pushed a commit
to wox/qmk_firmware
that referenced
this pull request
Aug 14, 2021
Co-authored-by: Ryan <[email protected]>
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a hidden bug, as it doesn't show up, because somebody got clever.
However, the keyboard header files will cause issues if the
LAYOUTmacro is changed, and the rev3.h file is not properly included, either.This fixes the issues and moves the layout macros into the rev1.h file.
There is NO functional change here, and this should be invisible to users.
Types of Changes
Issues Fixed or Closed by This PR
Checklist