Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Noxary 378 support #13156

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Initial Noxary 378 support #13156

merged 3 commits into from
Jul 30, 2021

Conversation

Gondolindrim
Copy link
Contributor

@Gondolindrim Gondolindrim commented Jun 9, 2021 •
edited
Loading

Adds support for the Noxary 378. This is a re-open of the PR #13155 , which was closed due to a wrong naming.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 9, 2021
@fauxpark fauxpark requested a review from a team June 9, 2021 17:49
@stale
Copy link

stale bot commented Jul 27, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jul 30, 2021
@drashna
Copy link
Member

drashna commented Jul 30, 2021

Thanks!

@drashna drashna merged commit a1f7d86 into qmk:master Jul 30, 2021
CharlesSchimmel pushed a commit to CharlesSchimmel/qmk_firmware that referenced this pull request Aug 8, 2021
@Gondolindrim
[Keyboard] Initial Noxary 378 support (qmk#13156)
7a2efea 
Co-authored-by: Gondolindrim <[email protected]>
VictorIsaacChavezEscamilla pushed a commit to VictorIsaacChavezEscamilla/qmk_firmware that referenced this pull request Aug 28, 2021
@Gondolindrim
[Keyboard] Initial Noxary 378 support (qmk#13156)
c54ee7e 
Co-authored-by: Gondolindrim <[email protected]>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Gondolindrim @nhongooi
[Keyboard] Initial Noxary 378 support (qmk#13156)
580c167 
Co-authored-by: Gondolindrim <[email protected]>
@chupotle chupotle mentioned this pull request May 17, 2023
Merged
7 tasks
@chupotle chupotle mentioned this pull request May 29, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gondolindrim @drashna @fauxpark