Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bcat's split_3x6_3 for Crkbd legacy removal #13097

Merged
merged 1 commit into from
Jun 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions layouts/community/split_3x6_3/bcat/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,9 @@

#pragma once

#if defined(KEYBOARD_crkbd_rev1_common) || defined(KEYBOARD_crkbd_rev1_legacy)
#if defined(KEYBOARD_crkbd_rev1)
# define EE_HANDS

# if defined(RGBLIGHT_ENABLE)
/* Configure RGB for underglow only (first six LEDs on each side). */
# undef RGBLED_SPLIT
# define RGBLED_SPLIT \
{ 6, 6 }
# endif

# if defined(RGB_MATRIX_ENABLE)
/* Limit max RGB LED current to avoid tripping controller fuse. */
# undef RGB_MATRIX_MAXIMUM_BRIGHTNESS
Expand Down
7 changes: 1 addition & 6 deletions layouts/community/split_3x6_3/bcat/rules.mk
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
ifeq ($(strip $(KEYBOARD)), crkbd/rev1/common)
BOOTLOADER = atmel-dfu # Elite-C

# Enable underglow only. (Split Common doesn't support RGB matrix on slave.)
RGBLIGHT_ENABLE = yes
else ifeq ($(strip $(KEYBOARD)), crkbd/rev1/legacy)
ifeq ($(strip $(KEYBOARD)), crkbd/rev1)
BOOTLOADER = atmel-dfu # Elite-C

RGB_MATRIX_ENABLE = yes # per-key RGB and underglow
Expand Down