Fix yeehaw #12934
Merged
Fix yeehaw #12934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
approved these changes
May 18, 2021
nooges
approved these changes
May 18, 2021
leland-kwong
pushed a commit
to leland-kwong/qmk_firmware
that referenced
this pull request
May 23, 2021
* CRLF? * Changed VIA keymap to use core KC_TRNS alias
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
* CRLF? * Changed VIA keymap to use core KC_TRNS alias
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
* CRLF? * Changed VIA keymap to use core KC_TRNS alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original user submission contained
#define ____ KC_TRNSwhich was suggested to be removed. However, this alias was left in the transparent layers of the VIA keymap.This is a quick fix to remedy that by replacing the undefined, non-core alias of four consecutive underscores with the core alias of seven consecutive underscores.
Types of Changes
Issues Fixed or Closed by This PR
KC_TRNSalias____has been lengthened to core alias_______.Checklist