Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong _BASE layer for SCRAMBLE default/OLED keymaps #12932

Merged
merged 1 commit into from
May 22, 2021
Merged

Fix wrong _BASE layer for SCRAMBLE default/OLED keymaps #12932

merged 1 commit into from
May 22, 2021

Conversation

jaygreco
Copy link
Contributor

Description

This fixes a silly copypasta error present in the default and OLED keymaps -- _BASE layer should be 0 and not 1. Tested and verified locally.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team May 22, 2021 05:33
@drashna
Copy link
Member

drashna commented May 22, 2021

Thanks!

@drashna drashna merged commit e17a6c4 into qmk:master May 22, 2021
leland-kwong pushed a commit to leland-kwong/qmk_firmware that referenced this pull request May 23, 2021
@jaygreco @leland-kwong
[Keymap] Fix wrong BASE layer for default and OLED keymaps (qmk#12932)
2ea125e
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@jaygreco @HokieGeek
[Keymap] Fix wrong BASE layer for default and OLED keymaps (qmk#12932)
e3c1e3e
@jaygreco jaygreco deleted the fix_scramble_keymaps branch November 15, 2021 06:59
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@jaygreco @nhongooi
[Keymap] Fix wrong BASE layer for default and OLED keymaps (qmk#12932)
d36af6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaygreco @drashna @fauxpark