Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ortho Candybar and NOP60 PCBs #12807

Merged
merged 2 commits into from
May 13, 2021
Merged

add support for ortho Candybar and NOP60 PCBs #12807

merged 2 commits into from
May 13, 2021

Conversation

npspears
Copy link
Contributor

@npspears npspears commented May 5, 2021

candybar_ortho is a drop-in replacement PCB for TKC Candy Bar

NOP60 is a universal 60% PCB with 2x3u support

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

candybar_ortho is a drop-in replacement PCB for TKC Candy Bar

NOP60 is a universal 60% PCB with 2x3u support
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 5, 2021
@drashna drashna requested a review from a team May 13, 2021 03:15
keyboards/checkerboards/candybar_ortho/candybar_ortho.h Outdated Show resolved Hide resolved
keyboards/checkerboards/candybar_ortho/candybar_ortho.h Outdated Show resolved Hide resolved
keyboards/checkerboards/candybar_ortho/candybar_ortho.h Outdated Show resolved Hide resolved
keyboards/checkerboards/candybar_ortho/rules.mk Outdated Show resolved Hide resolved
keyboards/checkerboards/candybar_ortho/readme.md Outdated Show resolved Hide resolved
@npspears
Copy link
Contributor Author

Thank you. Suggestions applied

@fauxpark fauxpark requested a review from a team May 13, 2021 05:30
@drashna
Copy link
Member

drashna commented May 13, 2021

Thanks!

@drashna drashna merged commit 54e7883 into qmk:master May 13, 2021
@npspears
Copy link
Contributor Author

I think we should also move Quark, Plexus75, and Pursuit 40 under the "checkerboards" umbrella as they are either sold at checkerboards.xyz, or they were designed and made by Checker Boards. That is, if it's possible. Please let me know what you think.

toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants