Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not leak weak mods from tap dance to the interrupting keypress #12471

Merged
merged 1 commit into from
Apr 25, 2021

Commits on Apr 3, 2021

  1. Do not leak weak mods from tap dance to the interrupting keypress

    Tap dance callbacks may register weak mods; one case when it happens
    is when a tap dance registers a key with modifiers.  When the tap
    dance is interrupted by pressing another key, these weak mods could
    affect the interrupting key (normally any stale weak mods are cleared
    at the start of action_exec() when handling a keypress event, but the
    tap dance interrupt check code is called later, and the weak mods left
    by that code were not cleared).  Add another clear_weak_mods() call to
    preprocess_tap_dance() to make sure that the interrupting keypress is
    not affected by unrelated weak mods from the previous tap dance.
    
    Fixes qmk#12445.
    sigprof committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    0b4ce8a View commit details
    Browse the repository at this point in the history