Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Add VSCode workspace files to .gitignore #12469

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

LuisMorenoSerrano
Copy link
Contributor

When using VSCode with QMK as IDE, if you create a .code-workspace file in root folder qmk_firmware (i.e. qmk_firmware.code-workspace or any other file name), this user specific file shows as modified.

Description

Add .code-workspace extension files to .gitignore.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unrelated changes.

@LuisMorenoSerrano
Copy link
Contributor Author

Sorry, this is my first pull request. I didn't know that subsequent local commits were added to pull request. I think I have fixed the situation, please tell me if you need some more changes of my own.

Thanks in advance,
Luis

@tzarc
Copy link
Member

tzarc commented Apr 25, 2021

All good, cheers!

@tzarc tzarc merged commit 417a07c into qmk:master Apr 25, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@LuisMorenoSerrano LuisMorenoSerrano deleted the lms_ace01 branch April 26, 2021 06:23
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants