Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QMK Configurator compilation for Kingly Keys Ave #12457

Merged
merged 1 commit into from
Apr 3, 2021
Merged

Fix QMK Configurator compilation for Kingly Keys Ave #12457

merged 1 commit into from
Apr 3, 2021

Conversation

noroadsleft
Copy link
Member

Description

QMK Configurator's API can't use the RGBLight configurator when it's defined at keymap level.

cc @The-Royal (keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
kingly_keys/ave: move RGBLight config to keyboard level
47f4edb 
QMK Configurator's API can't use the RGBLight configurator when it's defined at keymap level.
@noroadsleft noroadsleft requested a review from a team April 1, 2021 21:12
@github-actions github-actions bot added the keymap label Apr 1, 2021
@drashna drashna merged commit 59c8672 into qmk:master Apr 3, 2021
@noroadsleft noroadsleft deleted the fix/kingly_keys_ave branch April 3, 2021 12:22
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@noroadsleft @makenova
kingly_keys/ave: move RGBLight config to keyboard level (qmk#12457)
12a6d0e 
QMK Configurator's API can't use the RGBLight configurator when it's defined at keymap level.
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@noroadsleft @HokieGeek
kingly_keys/ave: move RGBLight config to keyboard level (qmk#12457)
506d441 
QMK Configurator's API can't use the RGBLight configurator when it's defined at keymap level.
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@noroadsleft @mrtnee
kingly_keys/ave: move RGBLight config to keyboard level (qmk#12457)
a1929e9 
QMK Configurator's API can't use the RGBLight configurator when it's defined at keymap level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noroadsleft @drashna @fauxpark