Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurator fixes for handwired/concertina/64key #12316

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

veikman
Copy link
Contributor

@veikman veikman commented Mar 21, 2021

Description

Fixes and enhancements for the use of QMK Configurator specifically with the Concertina, following a tip by @noroadsleft.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

* Fixed bug that was hiding a key in info.json.

* Improvements to presentation.
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look correct? (Disregarding that I have QWERTY assignments here instead of Colemak)

image

@veikman
Copy link
Contributor Author

veikman commented Mar 23, 2021

Yes, that’s correct as far as Configurator is able to render what’s really going on under Colemak. The biggest invisible customization is this snippet from keyboards/handwired/concertina/64key/keymaps/default/config.h:

#define LCPO_KEYS KC_LCTL, KC_TRNS, KC_LBRACKET
#define RCPC_KEYS KC_RCTL, KC_TRNS, KC_RBRACKET
#define LAPO_KEYS KC_LALT, KC_LSFT, KC_LBRACKET
#define RAPC_KEYS KC_RALT, KC_RSFT, KC_RBRACKET

Those custom space-cadet-style modifier-and-tap combinations all render as /( and /), but are really brackets and braces. I know of no better (i.e. renderable) way to implement the functionality.

@noroadsleft
Copy link
Member

Ah, Configurator's API doesn't have any support for being able to change the default Space Cadet keys, which are:

#define LCPO_KEYS KC_LCTL, KC_LSFT, KC_9
#define RCPC_KEYS KC_RCTL, KC_RSFT, KC_0
#define LAPO_KEYS KC_LALT, KC_LSFT, KC_9
#define RAPC_KEYS KC_RALT, KC_RSFT, KC_0

@noroadsleft noroadsleft merged commit d395c81 into qmk:master Mar 23, 2021
@noroadsleft
Copy link
Member

Thanks!

mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Mar 28, 2021
* Fixed bug that was hiding a key in info.json.

* Improvements to presentation.
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
* Fixed bug that was hiding a key in info.json.

* Improvements to presentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants