Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sirius UniGo66 touch-up #12280

Merged
merged 5 commits into from
Mar 19, 2021
Merged

Sirius UniGo66 touch-up #12280

merged 5 commits into from
Mar 19, 2021

Conversation

noroadsleft
Copy link
Member

Description

Minor codebase touch-up to fix some qmk info issues:

$ qmk info -kb sirius/unigo66
☒ keyboards/sirius/unigo66/unigo66.h: LAYOUT: Nested layout macro detected. Matrix data not available!
☒ keyboards/sirius/unigo66/unigo66.h: LAYOUT_beta_pcb: Nested layout macro detected. Matrix data not available!
...

cc @dhklein – shouldn't be any logic changes here.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team March 18, 2021 08:05
@noroadsleft noroadsleft merged commit 8dfe37a into qmk:master Mar 19, 2021
@noroadsleft noroadsleft deleted the rf/unigo66 branch March 19, 2021 19:36
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Mar 28, 2021
@noroadsleft @mrlinuxfish
Sirius UniGo66 touch-up (qmk#12280)
d7b27ed 
* un-nest layout macros

* use #pragma once include guard in unigo66.h

* unify rules.mk to QMK AVR template

- remove Bootloader selection comment block
- unify Build Option header comment
- align Build Option rules and inline comments

* remove unused LAYOUT_all macro

* update readme.md to match QMK template
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@noroadsleft @mrtnee
Sirius UniGo66 touch-up (qmk#12280)
c34cc44 
* un-nest layout macros

* use #pragma once include guard in unigo66.h

* unify rules.mk to QMK AVR template

- remove Bootloader selection comment block
- unify Build Option header comment
- align Build Option rules and inline comments

* remove unused LAYOUT_all macro

* update readme.md to match QMK template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @fauxpark