Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RGB Matrix suspend wake functions to BM40 #12246

Merged
merged 5 commits into from
Mar 25, 2021
Merged

Add RGB Matrix suspend wake functions to BM40 #12246

merged 5 commits into from
Mar 25, 2021

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Mar 15, 2021 •
edited
Loading

Description

Add RGB matrix suspend wake functions for BM40

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@filterpaper filterpaper changed the title Add suspend wake functions for BM40's RGB Matrix Add RGB Matrix suspend wake functions for three keyboards Mar 15, 2021
@filterpaper filterpaper mentioned this pull request Mar 15, 2021
Merged
14 tasks
@filterpaper filterpaper changed the title Add RGB Matrix suspend wake functions for three keyboards Add RGB Matrix suspend wake functions into four keyboards Mar 15, 2021
@filterpaper filterpaper marked this pull request as draft March 16, 2021 08:03
@filterpaper filterpaper changed the title Add RGB Matrix suspend wake functions into four keyboards Add RGB Matrix suspend wake functions into two keyboards Mar 16, 2021
@drashna
Copy link
Member

drashna commented Mar 17, 2021

Could you separate this out into two PRs? One for each keyboard?

@filterpaper filterpaper changed the title Add RGB Matrix suspend wake functions into two keyboards Add RGB Matrix suspend wake functions to BM40 Mar 17, 2021
@filterpaper filterpaper marked this pull request as ready for review March 17, 2021 04:37
@tzarc tzarc merged commit 29c82cf into qmk:master Mar 25, 2021
@filterpaper filterpaper deleted the bm40-rgbmatrix branch March 26, 2021 01:46
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Mar 28, 2021
@filterpaper @mrlinuxfish
Add RGB Matrix suspend wake functions to BM40 (qmk#12246)
be7b9c0 
* Add suspend wake functions for RGB Matrix

* Add suspension RGB functions to Planck/rev6 and Preonic/rev3

* Add suspend wake to Mark 65

* Revert changes to planck and preonic

* Remove changes to The Mark65

Co-authored-by: filterpaper <filterpaper@localhost>
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@filterpaper @mrtnee
Add RGB Matrix suspend wake functions to BM40 (qmk#12246)
bcce29e 
* Add suspend wake functions for RGB Matrix

* Add suspension RGB functions to Planck/rev6 and Preonic/rev3

* Add suspend wake to Mark 65

* Revert changes to planck and preonic

* Remove changes to The Mark65

Co-authored-by: filterpaper <filterpaper@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @tzarc