Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard PR #12230

Merged
merged 26 commits into from
Apr 3, 2021
Merged

New Keyboard PR #12230

merged 26 commits into from
Apr 3, 2021

Conversation

chrisquocmai
Copy link

@chrisquocmai chrisquocmai commented Mar 14, 2021 •
edited
Loading

Hello! I would like to add a new keyboard called the "pkb65."

Description

I have designed a PCB and Keyboard and have completed all prototyping phases. This PR marks the official finalized PCB for production.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 14, 2021
drashna
drashna requested changes Mar 17, 2021
View reviewed changes
keyboards/pkb65/config.h Outdated Show resolved Hide resolved
keyboards/pkb65/config.h Outdated Show resolved Hide resolved
keyboards/pkb65/config.h Outdated Show resolved Hide resolved
keyboards/pkb65/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pkb65/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pkb65/pkb65.h Outdated Show resolved Hide resolved
keyboards/pkb65/pkb65.h Outdated Show resolved Hide resolved
keyboards/pkb65/rules.mk Outdated Show resolved Hide resolved
keyboards/pkb65/rules.mk Outdated Show resolved Hide resolved
keyboards/pkb65/rules.mk Outdated Show resolved Hide resolved
chrisquocmai and others added 17 commits March 17, 2021 17:27
@chrisquocmai @drashna
Update keyboards/pkb65/config.h
0155d80 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/config.h
142fc77 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/config.h
b33680a 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/keymaps/default/keymap.c
5b84d19 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/keymaps/default/keymap.c
8cac643 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/keymaps/default/keymap.c
07b66f1 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/pkb65.h
7af92f7 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/pkb65.h
5853fb2 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/rules.mk
c3f9bc5 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/keymaps/default/keymap.c
d4c060c 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/rules.mk
c737e05 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/keymaps/via/keymap.c
534e70b 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai @drashna
Update keyboards/pkb65/keymaps/via/keymap.c
6afbcfe 
changes suggested by drashna

Co-authored-by: Drashna Jaelre <[email protected]>
@chrisquocmai
Update rules.mk
96c1e79
@chrisquocmai
Update config.h
2bfed52
@chrisquocmai
Update pkb65.h
fdaee34
@chrisquocmai
Update readme.md
cb4fae4
fauxpark
fauxpark requested changes Mar 18, 2021
View reviewed changes
keyboards/pkb65/rules.mk Outdated Show resolved Hide resolved
keyboards/pkb65/readme.md Outdated
@@ -0,0 +1,14 @@
# PKB65
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use Unix line endings for this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reuploaded the readme, please see the most recent commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still has Windows line endings.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok check it now, should be Unix LF now sorry!

keyboards/pkb65/readme.md Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Mar 18, 2021
View reviewed changes
keyboards/pkb65/config.h Outdated Show resolved Hide resolved
chrisquocmai and others added 6 commits March 17, 2021 23:58
@chrisquocmai @fauxpark
Update keyboards/pkb65/rules.mk
bbf11d2 
Suggested changes by fauxpark

Co-authored-by: Ryan <[email protected]>
@chrisquocmai @fauxpark
Update keyboards/pkb65/config.h
9bdaf89 
Changes suggested by fauxpark

Co-authored-by: Ryan <[email protected]>
@chrisquocmai
Update readme.md
0a060cf
@chrisquocmai
Delete readme.md
ea93b46
@chrisquocmai
unix style line endings for readme
67d3e21 
recreated the readme file with unix EoL in VS Code
@chrisquocmai
Delete readme.md
9a0a54e
@chrisquocmai
EoL Conversion to Unix
99f2aa3 
EoL Conversion to Unix
@fauxpark fauxpark requested a review from a team March 18, 2021 13:06
drashna
drashna requested changes Apr 3, 2021
View reviewed changes
keyboards/pkb65/config.h Outdated Show resolved Hide resolved
@chrisquocmai @drashna
Update keyboards/pkb65/config.h
c311beb 
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna
Copy link
Member

drashna commented Apr 3, 2021

Thanks!

@drashna drashna merged commit 8b98e67 into qmk:master Apr 3, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@chrisquocmai @drashna
@fauxpark @makenova
[Keyboard] Add pkb65 keyboard (qmk#12230)
81b34a2 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@chrisquocmai @drashna
@fauxpark @HokieGeek
[Keyboard] Add pkb65 keyboard (qmk#12230)
f4d45e8 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@chrisquocmai @drashna
@fauxpark @mrtnee
[Keyboard] Add pkb65 keyboard (qmk#12230)
cbc173e 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisquocmai @drashna @fauxpark