Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate some tmk_core files to quantum #11791

Merged
merged 2 commits into from
Feb 7, 2021
Merged

Migrate some tmk_core files to quantum #11791

merged 2 commits into from
Feb 7, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 4, 2021 •
edited
Loading

Description

Some low handing fruit in the tmk->quantum work

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team February 4, 2021 18:57
@zvecr zvecr marked this pull request as ready for review February 4, 2021 19:01
@tzarc tzarc requested a review from a team February 4, 2021 20:43
drashna
drashna approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, git ....

LGTM

@zvecr zvecr merged commit 99bffc2 into qmk:master Feb 7, 2021
flarestarwingz pushed a commit to flarestarwingz/qmk_firmware that referenced this pull request Feb 8, 2021
@zvecr @flarestarwingz
Migrate some tmk_core files to quantum (qmk#11791)
3fc18f7 
* Migrate some tmk_core files to quantum

* Fix build errors
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 10, 2021
@zvecr @sowbug
Migrate some tmk_core files to quantum (qmk#11791)
0fb1a30 
* Migrate some tmk_core files to quantum

* Fix build errors
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Migrate some tmk_core files to quantum (qmk#11791)
5467563 
* Migrate some tmk_core files to quantum

* Fix build errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark