Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move transport.c to QUANTUM_LIB_SRC #11751

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Move transport.c to QUANTUM_LIB_SRC #11751

merged 1 commit into from
Feb 1, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jan 31, 2021

Description

LTO can cause issues for the transport, and cause sync issues, especially if there is a lot of data.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

  • Issues with LTO being enabled and sync issues on split.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member Author

drashna commented Jan 31, 2021

Also, wondering if it's worth adding __attribute__((packed)) to the data structures, as well.

@tzarc
Copy link
Member

tzarc commented Jan 31, 2021

Also, wondering if it's worth adding __attribute__((packed)) to the data structures, as well.

In theory, yes. In practice, we're going to get a lot of "why doesn't split work after flashing?!?!?!". I guess we're not going to get anything drastically different compared to now, though.

@tzarc tzarc requested a review from a team January 31, 2021 22:07
@drashna
Copy link
Member Author

drashna commented Feb 1, 2021

In theory, yes. In practice, we're going to get a lot of "why doesn't split work after flashing?!?!?!". I guess we're not going to get anything drastically different compared to now, though.

Point. Should be fine without

mtei
mtei approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weak approve.

@mtei mtei requested a review from a team February 1, 2021 05:20
@tzarc tzarc merged commit 9591e99 into qmk:develop Feb 1, 2021
@drashna drashna deleted the fix/no_lto_transport branch February 4, 2021 01:34
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Move transport.c to QUANTUM_LIB_SRC (qmk#11751)
2c594aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei mtei approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @mtei