Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edc40 layout fix #11508

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Edc40 layout fix #11508

merged 1 commit into from
Jan 11, 2021

Conversation

ridingqwerty
Copy link
Contributor

Description

The initial submission of this board was incorrect. While it has 12 physical columns of keys, the wiring only utilizes 11 column pins. The layout in edc40.h and MATRIX_COLS in config.h have been amended to correct this.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@elfmimi
Copy link
Contributor

elfmimi commented Jan 11, 2021

It looks to me only the last commit is enough for what the description says.
Shouldn't you separately PR other 13 commits?

@ridingqwerty
Copy link
Contributor Author

Shouldn't you separately PR other 13 commits?

YES, ugh. Fixing that.

@ridingqwerty
Copy link
Contributor Author

Thanks again @elfmimi for the sharp eye.

@drashna drashna requested a review from a team January 11, 2021 09:01
@drashna drashna merged commit f8cbad2 into qmk:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants