Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CK60i support #11432

Merged
merged 7 commits into from
Jan 11, 2021
Merged

CK60i support #11432

merged 7 commits into from
Jan 11, 2021

Conversation

Gondolindrim
Copy link
Contributor

Add CK60i PCB support

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 4, 2021
@Gondolindrim Gondolindrim marked this pull request as ready for review January 4, 2021 21:58
@Gondolindrim
Copy link
Contributor Author

Due to the long commit list of rebase, I force reset to QMK master and cherry-picked the pertaining commits, then force-pushed with lease. This should make the commit history tidier and cleaner

drashna
drashna requested changes Jan 7, 2021
View reviewed changes
keyboards/ck60i/keymaps/default/keymap.c Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Jan 8, 2021
View reviewed changes
keyboards/ck60i/ck60i.c Outdated Show resolved Hide resolved
keyboards/ck60i/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team January 8, 2021 21:59
@drashna drashna merged commit e71f7a1 into qmk:master Jan 11, 2021
@drashna
Copy link
Member

drashna commented Jan 11, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gondolindrim @drashna @fauxpark @zvecr