Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add earth_rover keyboard #11405

Merged
merged 16 commits into from
Feb 7, 2021
Merged

[Keyboard] Add earth_rover keyboard #11405

merged 16 commits into from
Feb 7, 2021
+278 −0

Conversation

bigwheel
Copy link

@bigwheel bigwheel commented Jan 2, 2021

Add new keyboard earth_rover.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@bigwheel
Copy link
Author

bigwheel commented Jan 2, 2021 •
edited
Loading

I can't understand this travis error. Could anyone direct how to fix this ?

https://travis-ci.org/github/qmk/qmk_firmware/builds/752518641?utm_source=github_status&utm_medium=notification

Compiling: tmk_core/common/bootmagic.c                                                             cc1: fatal error: .build/obj_earth_rover/src/info_config.h: No such file or directory
compilation terminated.
make[1]: *** [tmk_core/rules.mk:394: .build/obj_earth_rover_default/common/bootmagic.o] Error 1
make[1]: *** Waiting for unfinished jobs....
 [ERRORS]
 | 
 | 
 | 
Make finished with errors
make: *** [Makefile:523: earth_rover:all] Error 1
The command "bash util/travis_build.sh" exited with 2.

@drashna
Copy link
Member

drashna commented Jan 7, 2021

Did you mean to target the develop branch here? I think there are some bugs with the develop branch right now.

@bigwheel
Copy link
Author

bigwheel commented Jan 7, 2021

Thanks! @drashna
https://docs.qmk.fm/#/pr_checklist?id=core-prs

I read this

must now target develop branch, which will subsequently be merged back to master on the breaking changes timeline

but I didn't read section title

Core PRs

I fix PR target now!

@bigwheel bigwheel changed the base branch from develop to master January 7, 2021 09:31
@bigwheel bigwheel requested a review from drashna January 24, 2021 01:04
@drashna drashna requested a review from a team January 30, 2021 02:56
noroadsleft
noroadsleft requested changes Feb 3, 2021
View reviewed changes
keyboards/earth_rover/config.h Outdated Show resolved Hide resolved
keyboards/earth_rover/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/earth_rover/readme.md Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Feb 5, 2021
View reviewed changes
keyboards/earth_rover/readme.md Outdated Show resolved Hide resolved
@drashna drashna changed the title Add earth_rover keyboard [Keyboard] Add earth_rover keyboard Feb 7, 2021
@drashna drashna merged commit 784a9cd into qmk:master Feb 7, 2021
@bigwheel bigwheel deleted the add-earth-rover branch February 8, 2021 02:27
jordanlewis added a commit to jordanlewis/qmk_firmware that referenced this pull request Feb 8, 2021
@jordanlewis
Merge remote-tracking branch 'upstream/master' into master
6b70057 
* upstream/master: (723 commits)
  [Keyboard] Add The Stick keyboard (qmk#11745)
  [Docs] Update isp_flashing_guide.md (qmk#11777)
  [Keymap] Update keymap for keebio/nyquist (qmk#11734)
  [Keymap] Shadyproject/bfo9000 (qmk#11753)
  [Keymap] Update community ortholinear 4x12 keymap: junonum (qmk#11757)
  [Keyboard] Add my keymap for Mark65 (qmk#11717)
  [Keyboard] Add nknl7jp keyboard (qmk#11591)
  [Keyboard] Add nknl7en keyboard (qmk#11590)
  [Keyboard] Add ergoarrows keyboard (qmk#11592)
  [Keyboard] Add Hi-Tek AIM-65 keyboard (qmk#11623)
  [Keyboard] Add earth_rover keyboard (qmk#11405)
  [Keyboard] Whale 75 (qmk#11486)
  [Keyboard] VIA fix firmware sizes (qmk#11770)
  Fixed pin assignment on KBD8X Hotswap by Lucid (qmk#11807)
  Manual formatting fix for serial_uart.c (qmk#11806)
  [CI] Auto Formatting - Swap from direct commit to PR (qmk#11229)
  [Keyboard] add info.json of Sparrow62 (qmk#11740)
  Serial refactor (qmk#11521)
  update lck75 json file (qmk#11798)
  Manually run formatting job (qmk#11797)
  ...
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Feb 10, 2021
@bigwheel @noroadsleft @sowbug
[Keyboard] Add earth_rover keyboard (qmk#11405)
d15faf1 
* Just ./util/new_keyboard.sh earth_rover

* Update readme.md

* Create key layout

* Setup config.h

* Add default keymap

* Fix pins

* Update flash command

* Write info.json

* Add reset instruction

* Change bootloader setting

* Format new C files

* Empty commit for kicking CI

* Update keyboards/earth_rover/config.h

Co-authored-by: James Young <[email protected]>

* Update keyboards/earth_rover/keymaps/default/keymap.c

Co-authored-by: James Young <[email protected]>

* Update readme.md

* Update keyboards/earth_rover/readme.md

Co-authored-by: James Young <[email protected]>

Co-authored-by: James Young <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bigwheel @drashna @fauxpark @noroadsleft