Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OLED Initialized checks #11129

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Added OLED Initialized checks #11129

merged 1 commit into from
Dec 6, 2020

Conversation

XScorpion2
Copy link
Contributor

Description

Added checks before transmits to see if the oled was properly initialized. If not, these checks will early out before the i2c transmit calls reducing wait timeouts from lagging the keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@XScorpion2
Added OLED Initialized checks for functions that transmit data to red…
f2860b2 
…uce timeouts if there are oled problems on boot
@github-actions github-actions bot added the core label Dec 5, 2020
@tzarc tzarc requested a review from a team December 6, 2020 01:51
@fauxpark
Copy link
Member

fauxpark commented Dec 6, 2020

Thanks!

@fauxpark fauxpark merged commit cba7609 into qmk:master Dec 6, 2020
@XScorpion2 XScorpion2 deleted the oled_init_checks branch December 6, 2020 04:43
@drashna drashna mentioned this pull request Dec 21, 2020
Closed
14 tasks
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@XScorpion2 @xgnxs
Added OLED Initialized checks (qmk#11129)
885f2cf
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 13, 2021
@XScorpion2 @drashna
Added OLED Initialized checks (qmk#11129)
d6c468d
mgmanzella pushed a commit to mgmanzella/qmk_firmware that referenced this pull request Feb 16, 2021
@XScorpion2 @mgmanzella
Added OLED Initialized checks (qmk#11129)
9c47916
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@XScorpion2
Added OLED Initialized checks (qmk#11129)
b4a9971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XScorpion2 @fauxpark @tzarc