Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA Support for Dimple Plus #11026

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Add VIA Support for Dimple Plus #11026

merged 1 commit into from
Nov 26, 2020

Conversation

jackytrabbit
Copy link
Contributor

Add VIA Support for Dimple Plus

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jackytrabbit
Add VIA Support for Dimple Plus
4376b13 
Add VIA Support for Dimple Plus
@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Nov 24, 2020
@jackytrabbit jackytrabbit mentioned this pull request Nov 24, 2020
Merged
6 tasks
@drashna drashna requested a review from a team November 25, 2020 20:01
@fauxpark fauxpark requested a review from a team November 26, 2020 11:52
@Erovia Erovia merged commit 10d9e8e into qmk:master Nov 26, 2020
@jackytrabbit jackytrabbit deleted the commits branch December 27, 2020 04:25
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@jackytrabbit @xgnxs
Add VIA Support for Dimple Plus (qmk#11026)
70c5a1d 
Add VIA Support for Dimple Plus
@jackytrabbit jackytrabbit mentioned this pull request Sep 11, 2022
Merged
6 tasks
@jackytrabbit jackytrabbit mentioned this pull request Nov 30, 2022
Closed
6 tasks
@jackytrabbit jackytrabbit mentioned this pull request Dec 10, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackytrabbit @drashna @Erovia @fauxpark