Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIA Support: E6V2 BMC editions #10969

Merged
merged 5 commits into from
Nov 18, 2020
Merged

VIA Support: E6V2 BMC editions #10969

merged 5 commits into from
Nov 18, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Nov 18, 2020 •
edited
Loading

Description

Add VIA keymaps to the 2 BMC edition PCBs present in R1 and R2.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin added the via Adds via keymap and/or updates keyboard for via support label Nov 18, 2020
@zvecr zvecr requested a review from a team November 18, 2020 17:59
@Erovia Erovia requested review from a team and zvecr November 18, 2020 19:45
@zvecr zvecr merged commit 0f8b0d9 into qmk:master Nov 18, 2020
@zvecr
Copy link
Member

zvecr commented Nov 18, 2020

Thanks!

@mechmerlin mechmerlin mentioned this pull request Nov 19, 2020
Merged
6 tasks
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@mechmerlin @zvecr @xgnxs
VIA Support: E6V2 BMC editions (qmk#10969)
5bbddd6 
* update readme with relevant PCB versioning

* Add VIA keymap to e6v2 LE BMC

* add via keymap

* Update keyboards/exclusive/e6v2/le_bmc/keymaps/via/keymap.c

Co-authored-by: Joel Challis <[email protected]>

* Update keyboards/exclusive/e6v2/oe_bmc/keymaps/via/keymap.c

Co-authored-by: Joel Challis <[email protected]>

Co-authored-by: Joel Challis <[email protected]>
@mechmerlin mechmerlin deleted the feature/e6v2_via branch January 26, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mechmerlin @zvecr @Erovia