Adds .qmk file type as a target for QMK Toolbox #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we agree not to merge this until we have a version of the flasher that makes use of it? That will also give us an opportunity to make sure the info file contains all of the information we want to use in the flasher. |
|
Sure! :) |
|
Idk if you've already thought of this, but the format should include the flash capacity of the MCU, so that we can alert the user beforehand if the file is too big to flash successfully. |
|
I think I messaged you about this, but for posterity, we talked about the app handling that side of things, right? |
|
Yep, that's right. |
jackhumbert
changed the title
3 tasks
jackhumbert
force-pushed
the
qmk_file_type
branch
from
a76e341
to
cda0c22
Compare
jackhumbert
changed the title
|
We make use of this in the Toolbox, and |
kgwong
pushed a commit
to kgwong/qmk_firmware
that referenced
this pull request
Nov 26, 2017
* adds .qmk file type as a target * adds info.json with vendor and product * add files for qmk info script * add layout file for planck * ignore .qmk files * more settings * update rules for avr and chibios * update .qmk generation for info.json and inheritence
LovesTha
pushed a commit
to LovesTha/qmk_firmware
that referenced
this pull request
Jul 24, 2018
* adds .qmk file type as a target * adds info.json with vendor and product * add files for qmk info script * add layout file for planck * ignore .qmk files * more settings * update rules for avr and chibios * update .qmk generation for info.json and inheritence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with the
qmktarget (i.e.make planck:default:qmk) will generate a .qmk file that contains the .hex (named firmware.hex), along with all the contents of the keymap/keymap folder, for reading by the firmware flasher.This is now for the Toolbox, not the flasher :)