[Keyboard] Fix function references IDB 60 #10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
Oct 31, 2020
Co-authored-by: Ryan <[email protected]>
|
@itspngu Just a heads up on the change |
fauxpark
approved these changes
Oct 31, 2020
itspngu
suggested changes
Oct 31, 2020
There was a problem hiding this comment.
Hey! Thanks, I actually meant to look into the reports of this not compiling anymore, but never got around to it. Since you're already on this, apparently these got mixed up somewhere down the line, so the LEDs are driven in inverse (they're on when they're meant to be off and vice versa).
Co-authored-by: Thorben <[email protected]>
|
Not a problem, at all! Mostly wanted to make sure it compiled, but more than willing to add some other fixes, too! |
Awesome, thanks! |
morrijr
pushed a commit
to morrijr/qmk_firmware
that referenced
this pull request
Nov 1, 2020
Co-authored-by: Ryan <[email protected]> Co-authored-by: Thorben <[email protected]>
14 tasks
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
Co-authored-by: Ryan <[email protected]> Co-authored-by: Thorben <[email protected]>
ringmaster
pushed a commit
to ringmaster/qmk_firmware
that referenced
this pull request
Nov 5, 2020
Co-authored-by: Ryan <[email protected]> Co-authored-by: Thorben <[email protected]>
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Nov 8, 2020
Co-authored-by: Ryan <[email protected]> Co-authored-by: Thorben <[email protected]>
ea2809
pushed a commit
to ea2809/qmk_firmware
that referenced
this pull request
Jan 11, 2021
Co-authored-by: Ryan <[email protected]> Co-authored-by: Thorben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist