Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial beta firmware for the Rocketboard-16 macro/num pad #10688

Merged
merged 23 commits into from
Nov 1, 2020

Conversation

fl3tching101
Copy link
Contributor

Description

Hardware setup should all be correct, working on establishing the default keymap for certain and other functionality - i.e. the OLED display currently only has test text output on it. Most importantly need to ensure Via support with main branch.

Types of Changes

Full keyboard addition - initial commit

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

… really bright), added the ability to switch LED mode with left encoder click, and added via support (untested)
Merging upstream main project with forked master
keyboards/rocketboard_16/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/rules.mk Outdated Show resolved Hide resolved
@drashna drashna added keyboard and removed keymap labels Oct 19, 2020
@drashna drashna requested a review from a team October 19, 2020 00:04
@fl3tching101 fl3tching101 requested review from drashna and removed request for a team October 19, 2020 00:27
keyboards/rocketboard_16/config.h Outdated Show resolved Hide resolved
keyboards/rocketboard_16/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/rocketboard_16.c Outdated Show resolved Hide resolved
keyboards/rocketboard_16/rules.mk Outdated Show resolved Hide resolved
keyboards/rocketboard_16/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team October 19, 2020 07:04
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, actually this is missing an info.json.

keyboards/rocketboard_16/rules.mk Outdated Show resolved Hide resolved
- Changed the dimming step size for smoother dimming with the reduced range
- Added lots of OLED functionality - QMK logo and title at top, num/caps/scroll lock status, and backlight brightness level
- Updated the rules.mk file to comply more closely with the formatting guidelines
keyboards/rocketboard_16/rules.mk Outdated Show resolved Hide resolved
Co-authored-by: Ryan <[email protected]>
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna drashna merged commit 9f0dbc2 into qmk:master Nov 1, 2020
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
* Firmware initial commit, still has a few bugs - mainly rotary encoders do not work and needs cleaning up

* Fixed the volume control issue and limited the RGB brightness (can be really bright), added the ability to switch LED mode with left encoder click, and added via support (untested)

* Remove define that should go in config.h

* Removed define that should be in config.h

* Removed LTO_ENABLE as suggested - has issues on ARM

Co-authored-by: Drashna Jaelre <[email protected]>

* Added the correct define for OLED screen size

* Applied suggested change to remove description

Co-authored-by: Ryan <[email protected]>

* Made suggested change to remove backslashes

Co-authored-by: Ryan <[email protected]>

* Suggested change made to rgblight

Co-authored-by: Ryan <[email protected]>

* Suggested change made to rgblight

Co-authored-by: Ryan <[email protected]>

* Suggested change made to remove backslashes

Co-authored-by: Ryan <[email protected]>

* Suggested change made to rgblight

Co-authored-by: Ryan <[email protected]>

* Update keyboards/rocketboard_16/rocketboard_16.c

Co-authored-by: Ryan <[email protected]>

* Added suggested comments

Co-authored-by: Ryan <[email protected]>

* Made suggested changes to rules file

Co-authored-by: Ryan <[email protected]>

* Added suggested change to rgblight

Co-authored-by: Ryan <[email protected]>

* Added info.json for QMK configurator

* Update readme.md

* This change makes the firmware work... through magic... seriously, no idea - but it works!

* Updated dimming step, OLED functionality, and rules for formatting

- Changed the dimming step size for smoother dimming with the reduced range
- Added lots of OLED functionality - QMK logo and title at top, num/caps/scroll lock status, and backlight brightness level
- Updated the rules.mk file to comply more closely with the formatting guidelines

* Fixed tab issues

Co-authored-by: Ryan <[email protected]>

* Updated to use bootmagic lite with the key that usually turns rgb on/off

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
ringmaster pushed a commit to ringmaster/qmk_firmware that referenced this pull request Nov 5, 2020
* Firmware initial commit, still has a few bugs - mainly rotary encoders do not work and needs cleaning up

* Fixed the volume control issue and limited the RGB brightness (can be really bright), added the ability to switch LED mode with left encoder click, and added via support (untested)

* Remove define that should go in config.h

* Removed define that should be in config.h

* Removed LTO_ENABLE as suggested - has issues on ARM

Co-authored-by: Drashna Jaelre <[email protected]>

* Added the correct define for OLED screen size

* Applied suggested change to remove description

Co-authored-by: Ryan <[email protected]>

* Made suggested change to remove backslashes

Co-authored-by: Ryan <[email protected]>

* Suggested change made to rgblight

Co-authored-by: Ryan <[email protected]>

* Suggested change made to rgblight

Co-authored-by: Ryan <[email protected]>

* Suggested change made to remove backslashes

Co-authored-by: Ryan <[email protected]>

* Suggested change made to rgblight

Co-authored-by: Ryan <[email protected]>

* Update keyboards/rocketboard_16/rocketboard_16.c

Co-authored-by: Ryan <[email protected]>

* Added suggested comments

Co-authored-by: Ryan <[email protected]>

* Made suggested changes to rules file

Co-authored-by: Ryan <[email protected]>

* Added suggested change to rgblight

Co-authored-by: Ryan <[email protected]>

* Added info.json for QMK configurator

* Update readme.md

* This change makes the firmware work... through magic... seriously, no idea - but it works!

* Updated dimming step, OLED functionality, and rules for formatting

- Changed the dimming step size for smoother dimming with the reduced range
- Added lots of OLED functionality - QMK logo and title at top, num/caps/scroll lock status, and backlight brightness level
- Updated the rules.mk file to comply more closely with the formatting guidelines

* Fixed tab issues

Co-authored-by: Ryan <[email protected]>

* Updated to use bootmagic lite with the key that usually turns rgb on/off

Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants