Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back to the old matrix (Take the blue pill) #10568

Merged
merged 2 commits into from
Dec 6, 2020
Merged

Revert back to the old matrix (Take the blue pill) #10568

merged 2 commits into from
Dec 6, 2020

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Oct 7, 2020 •
edited
Loading

Description

Apparently our matrix changes to accomodate debounce were flawed and didn't work with Duck TC-V3, this commit reverts back to what it was before.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin mechmerlin mentioned this pull request Oct 7, 2020
Merged
6 tasks
@drashna drashna requested a review from a team October 16, 2020 04:34
@stale
Copy link

stale bot commented Nov 30, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Dec 6, 2020
@tzarc tzarc merged commit a6a1289 into qmk:master Dec 6, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@mechmerlin @xgnxs
Revert back to the old matrix (Take the blue pill) (qmk#10568)
bd3b328 
* revert back to the old matrix.

* apparently I can't count, J is the 19th not the 20th column
@mechmerlin mechmerlin deleted the feature/tcv3_fix branch January 26, 2021 14:55
mgmanzella pushed a commit to mgmanzella/qmk_firmware that referenced this pull request Feb 16, 2021
@mechmerlin @mgmanzella
Revert back to the old matrix (Take the blue pill) (qmk#10568)
b880549 
* revert back to the old matrix.

* apparently I can't count, J is the 19th not the 20th column
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mechmerlin @drashna @tzarc