Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: More Technical: doesn't say where keymaps/ is #290

Closed
adiabatic opened this issue Apr 27, 2016 · 1 comment
Closed

README: More Technical: doesn't say where keymaps/ is #290

adiabatic opened this issue Apr 27, 2016 · 1 comment

Comments

@adiabatic
Copy link
Contributor

I got a little lost on step 4: it says to copy keymaps/default/keymap.c elsewhere, but it doesn't mention that keymaps/ is in …/qmk_firmware/keyboard/ergodox_ez. Could the instructions be updated to nudge the user in the right direction of the proper subirectory?

ezuk pushed a commit that referenced this issue Apr 29, 2016
@ezuk
Copy link
Contributor

ezuk commented Apr 29, 2016

Thanks for the feedback! Done.

@ezuk ezuk closed this as completed Apr 29, 2016
ryaninvents pushed a commit to ryaninvents/qmk_firmware that referenced this issue Aug 12, 2016
BlueTufa pushed a commit to BlueTufa/qmk_firmware that referenced this issue Aug 6, 2021
- symptom, being unable to change any layer or (kc) style codes once
 they were set in the UI.
 - Use correct regenerated keycode, not the imported keycode, so
 export works correctly again

Longer description:

A coding error. When we import codes from a JSON file we parse them and
set their original KC_CODE to that configurator can export them
correctly again.

e.g. TG(3) would be internally referred to as TG(layer). When exported
it would save TG(3).

The bug was on import. The key was correctly parsed as an layer key, but
then it was incorrectly imported to be TG(3) instead of TG(layer). This
caused the export to save the wrong data because the code could not be
correctly looked up, so it was treated like an ANY key.

This also affected any container keys, which would create a similarly
bogus key mapping.
jiaxin96 pushed a commit to Oh-My-Mechanical-Keyboard/qmk_firmware that referenced this issue Dec 20, 2022
* Added support for Velocifire Sun20pro numpad

* Cleaned up formatting

* Added default keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants