[Bugfix] Check QGF's bpp against display's native_bits_per_pixel (#19995

)
qmk · Apr 3, 2023 · 15a106b · 15a106b
1 parent ac9f9f9
commit 15a106b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/quantum/painter/qp_draw_image.c b/quantum/painter/qp_draw_image.c
@@ -273,6 +273,10 @@ static bool qp_drawimage_recolor_impl(painter_device_t device, uint16_t x, uint1
  if (ret && output_state.pixel_write_pos > 0) {
  ret &= driver->driver_vtable->pixdata(device, qp_internal_global_pixdata_buffer, output_state.pixel_write_pos);
  }
+ } else if (frame_info->bpp != driver->native_bits_per_pixel) {
+ // Prevent stuff like drawing 24bpp images on 16bpp displays
+ qp_dprintf("Image's bpp doesn't match the target display's native_bits_per_pixel\n");
+ return false;
  } else {
  // Set up the output state
  struct qp_internal_byte_output_state output_state = {.device = device, .byte_write_pos = 0, .max_bytes = qp_internal_num_pixels_in_buffer(device) * driver->native_bits_per_pixel / 8};