Skip to content

Commit

Permalink
Rgbkb/keeb fixes (#17932)
Browse files Browse the repository at this point in the history
* Disable console by default for better bios & reboot behavior

* Remove custom matrix

* Disable console by default for better bios & reboot behavior

* PR feedback
  • Loading branch information
XScorpion2 committed Aug 7, 2022
1 parent a6ea760 commit 034e266
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 86 deletions.
3 changes: 2 additions & 1 deletion keyboards/rgbkb/common/common_oled.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
#include "oled_driver.h"
#include "rgb_matrix.h"

// for memcpy
// for memcpy & snprintf
#include <stdio.h>
#include <string.h>
#include <transactions.h>

Expand Down
76 changes: 0 additions & 76 deletions keyboards/rgbkb/mun/matrix.c

This file was deleted.

5 changes: 1 addition & 4 deletions keyboards/rgbkb/mun/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ QUANTUM_LIB_SRC += i2c_master.c
BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite
MOUSEKEY_ENABLE = no # Mouse keys
EXTRAKEY_ENABLE = yes # Audio control and System control
CONSOLE_ENABLE = yes # Console for debug
CONSOLE_ENABLE = no # Console for debug
COMMAND_ENABLE = no # Commands for debug and configuration
NKRO_ENABLE = yes # Enable N-Key Rollover
AUDIO_ENABLE = no # Audio output
Expand All @@ -38,7 +38,4 @@ OPT = 3

OPT_DEFS += -DOLED_FONT_H=\"keyboards/rgbkb/common/glcdfont.c\"

# matrix optimisations
SRC += matrix.c

DEFAULT_FOLDER = rgbkb/mun/rev1
6 changes: 1 addition & 5 deletions keyboards/rgbkb/sol3/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ QUANTUM_LIB_SRC += i2c_master.c
BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite
MOUSEKEY_ENABLE = no # Mouse keys
EXTRAKEY_ENABLE = yes # Audio control and System control
CONSOLE_ENABLE = yes # Console for debug
CONSOLE_ENABLE = no # Console for debug
COMMAND_ENABLE = no # Commands for debug and configuration
NKRO_ENABLE = yes # Enable N-Key Rollover
AUDIO_ENABLE = yes # Audio output
Expand All @@ -42,8 +42,4 @@ OPT = 3

OPT_DEFS += -DOLED_FONT_H=\"keyboards/rgbkb/common/glcdfont.c\"

# TODO: Implement fast matrix scanning
# matrix optimisations
# SRC += matrix.c

DEFAULT_FOLDER = rgbkb/sol3/rev1

0 comments on commit 034e266

Please sign in to comment.